* [PATCH] generic/590: add _require_xfs_io_command "falloc"
@ 2019-12-09 17:14 Luis Henriques
2019-12-10 18:42 ` Omar Sandoval
0 siblings, 1 reply; 2+ messages in thread
From: Luis Henriques @ 2019-12-09 17:14 UTC (permalink / raw)
To: Eryu Guan, Omar Sandoval; +Cc: fstests, Luis Henriques
Without this check the test will fail with message:
fallocate: Operation not supported
Instead, with this _require_xfs_io_command, the test will be skipped
instead if falloc isn't supported.
Signed-off-by: Luis Henriques <lhenriques@suse.com>
---
tests/generic/590 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/generic/590 b/tests/generic/590
index 80a665c6b001..2670fe99d21f 100755
--- a/tests/generic/590
+++ b/tests/generic/590
@@ -34,6 +34,7 @@ rm -f $seqres.full
_supported_fs generic
_supported_os Linux
_require_scratch_nocheck
+_require_xfs_io_command "falloc"
maxextlen=$((0x1fffff))
bs=4096
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/590: add _require_xfs_io_command "falloc"
2019-12-09 17:14 [PATCH] generic/590: add _require_xfs_io_command "falloc" Luis Henriques
@ 2019-12-10 18:42 ` Omar Sandoval
0 siblings, 0 replies; 2+ messages in thread
From: Omar Sandoval @ 2019-12-10 18:42 UTC (permalink / raw)
To: Luis Henriques; +Cc: Eryu Guan, fstests
On Mon, Dec 09, 2019 at 05:14:52PM +0000, Luis Henriques wrote:
> Without this check the test will fail with message:
>
> fallocate: Operation not supported
>
> Instead, with this _require_xfs_io_command, the test will be skipped
> instead if falloc isn't supported.
Thanks, I missed this.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Luis Henriques <lhenriques@suse.com>
> ---
> tests/generic/590 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/590 b/tests/generic/590
> index 80a665c6b001..2670fe99d21f 100755
> --- a/tests/generic/590
> +++ b/tests/generic/590
> @@ -34,6 +34,7 @@ rm -f $seqres.full
> _supported_fs generic
> _supported_os Linux
> _require_scratch_nocheck
> +_require_xfs_io_command "falloc"
>
> maxextlen=$((0x1fffff))
> bs=4096
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-10 18:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-09 17:14 [PATCH] generic/590: add _require_xfs_io_command "falloc" Luis Henriques
2019-12-10 18:42 ` Omar Sandoval
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox