From: Anju T Sudhakar <anju@linux.vnet.ibm.com>
To: fstests@vger.kernel.org
Cc: anju@linux.vnet.ibm.com
Subject: [PATCH 1/3] xfs/504: Add scratch_mount before checking for xfs_scrub unicode support.
Date: Mon, 28 Jun 2021 14:22:57 +0530 [thread overview]
Message-ID: <20210628085259.120666-2-anju@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210628085259.120666-1-anju@linux.vnet.ibm.com>
We may not detect the error `Inappropriate ioctl for device`, while running
`$XFS_IO_PROG -c "scrub probe" "$mountpoint"`, if scratch device is not
mounted before invoking _check_xfs_scrub_does_unicode(). So do
_scratch_mount before checking for xfs_scrub support.
Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
---
tests/xfs/504 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/xfs/504 b/tests/xfs/504
index 40318314..291ee4e4 100755
--- a/tests/xfs/504
+++ b/tests/xfs/504
@@ -21,8 +21,11 @@ _require_xfs_io_command 'label'
echo "Silence is golden."
+_scratch_mkfs > /dev/null
+_scratch_mount
want_scrub=
_check_xfs_scrub_does_unicode "$SCRATCH_MNT" "$SCRATCH_DEV" && want_scrub=yes
+_scratch_unmount
filter_scrub() {
grep 'Unicode' | sed -e 's/^.*Duplicate/Duplicate/g'
--
2.31.1
next prev parent reply other threads:[~2021-06-28 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 8:52 [PATCH 0/3] xfstest random fixes Anju T Sudhakar
2021-06-28 8:52 ` Anju T Sudhakar [this message]
2021-06-28 15:43 ` [PATCH 1/3] xfs/504: Add scratch_mount before checking for xfs_scrub unicode support Darrick J. Wong
2021-06-28 8:52 ` [PATCH 2/3] xfs/514: Check xfsprogs version for verifying the xfs_db commands Anju T Sudhakar
2021-06-28 14:16 ` Zorro Lang
2021-06-28 15:35 ` Darrick J. Wong
2021-07-04 7:29 ` Anju T Sudhakar
2021-06-28 8:52 ` [PATCH 3/3] xfs/515: Check xfsprogs version for testing xfs_quota commands Anju T Sudhakar
2021-06-28 14:19 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628085259.120666-2-anju@linux.vnet.ibm.com \
--to=anju@linux.vnet.ibm.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox