public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Anju T Sudhakar <anju@linux.vnet.ibm.com>
To: fstests@vger.kernel.org
Cc: anju@linux.vnet.ibm.com
Subject: [PATCH 3/3] xfs/515: Check xfsprogs version for testing xfs_quota commands
Date: Mon, 28 Jun 2021 14:22:59 +0530	[thread overview]
Message-ID: <20210628085259.120666-4-anju@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210628085259.120666-1-anju@linux.vnet.ibm.com>

xfs_quota command 'limit' is reformated in xfsprogs version v5.5.0, to
make it suitable for this(xfs/515) test case. So the test case will
flag failure while running with xfsprogs version less than v5.5, even
though `limit` is documented in xfs_quota manpage. So skip this test for
xfsprogs versions less than v5.5.

Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
---
 tests/xfs/515 | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/tests/xfs/515 b/tests/xfs/515
index 32216fe6..5eb97aff 100755
--- a/tests/xfs/515
+++ b/tests/xfs/515
@@ -27,6 +27,11 @@ _require_test
 echo "Silence is golden"
 
 MANPAGE=$($MAN_PROG --path xfs_quota)
+# xfs_quota command 'limit' is reformated in xfsprogs version v5.5.0,
+# to make it suitable for this test case. For xfprogs versions less than
+# v5.5.0, this test case can not detect the command 'limit'.
+req_version=$($XFS_DB_PROG -V | cut -d" " -f3)
+req_command="limit"
 
 case "$MANPAGE" in
 *.gz|*.z\|*.Z)	CAT=zcat;;
@@ -36,8 +41,14 @@ case "$MANPAGE" in
 esac
 _require_command `which $CAT` $CAT
 
-for COMMAND in `$XFS_QUOTA_PROG -x -c help $file | awk '{print $1}' | grep -v "^Use"`; do
-  $CAT "$MANPAGE" | egrep -q "^\.B.*$COMMAND" || \
+for COMMAND in `$XFS_QUOTA_PROG -x -c help $file | awk '{print $1}' | grep -v "^Use"`;
+do
+	if [ "$req_version" \< "5.5.0" ]; then
+		if [ "$COMMAND" == "$req_command" ];then
+			continue
+		fi
+	fi
+	$CAT "$MANPAGE" | egrep -q "^\.B.*$COMMAND" || \
 	echo "$COMMAND not documented in the xfs_quota manpage"
 done
 
-- 
2.31.1


  parent reply	other threads:[~2021-06-28  8:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28  8:52 [PATCH 0/3] xfstest random fixes Anju T Sudhakar
2021-06-28  8:52 ` [PATCH 1/3] xfs/504: Add scratch_mount before checking for xfs_scrub unicode support Anju T Sudhakar
2021-06-28 15:43   ` Darrick J. Wong
2021-06-28  8:52 ` [PATCH 2/3] xfs/514: Check xfsprogs version for verifying the xfs_db commands Anju T Sudhakar
2021-06-28 14:16   ` Zorro Lang
2021-06-28 15:35   ` Darrick J. Wong
2021-07-04  7:29     ` Anju T Sudhakar
2021-06-28  8:52 ` Anju T Sudhakar [this message]
2021-06-28 14:19   ` [PATCH 3/3] xfs/515: Check xfsprogs version for testing xfs_quota commands Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628085259.120666-4-anju@linux.vnet.ibm.com \
    --to=anju@linux.vnet.ibm.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox