From: David Howells <dhowells@redhat.com>
To: fstests@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>, Eryu Guan <guan@eryu.me>,
Marc Dionne <marc.dionne@auristor.com>,
Jeffrey Altman <jaltman@auristor.com>,
linux-afs@lists.infradead.org
Subject: [PATCH v2 0/6] xfstests: Add support for using xfstests to test AFS
Date: Mon, 24 Apr 2023 15:10:36 +0100 [thread overview]
Message-ID: <20230424141042.450535-1-dhowells@redhat.com> (raw)
Here's a set of patches that make xfstests (mostly) work with the in-kernel
AFS client. It has to allow for a number of features of AFS, in
particular:
(*) AFS has its own permissions service that makes use of authentication
tokens obtained from such as kerberos and uses this in combination
with ACLs to determine file access rights. This overrides the use of
UNIX permissions and using su to impersonate another user doesn't
work.
(*) AFS sets the inode UID field to the user ID associated with the
authentication token, not the client's fsuid when creating.
(*) AFS doesn't support SUID/SGID/SVTX bits and doesn't propagate SGID on
directories, though it will propagate the GID.
(*) chown is rejected unless you have an authentication token that
indicates you're the owner of the file.
I've added fixes/workarounds for the above. There are five -g quick tests
that fail if unauthenticated:
- generic/258
- generic/634
Fail because they try to use dates that the server refuses to
handle (and gives EOVERFLOW for).
- generic/478
Fails because AFS file locking can't lock ranges.
- generic/633
Fails because of chown.
- generic/696
Fails because AFS doesn't propagate SGID in mkdir. This may be a
client (kernel) bug, a server bug or a design feature.
And if authenticated, the following additional failures occur because AFS
uses its own ACLs and authentication:
- generic/087
- generic/126
- generic/193
- generic/088
David
Changes
=======
ver #2)
- Rebased.
- Dropped the patches to handle the DIO blocksize being 1 as none of the
quick tests now use it on AFS.
- Changed generic/696 to not supply "noacl" to AFS.
Link: https://lore.kernel.org/r/162194962878.4011860.5561077785368723619.stgit@warthog.procyon.org.uk/ # v1
David Howells (6):
Add AFS support
generic/314, afs: Allow for a filesystem that doesn't honour SGID
inheritance
generic/317, afs: Allow for a filesystem not to honour the local
uid/gid
generic/123, generic/128, afs: Allow for an fs that does its own perm
management
generic/531: Check for O_TMPFILE
generic/696: AFS doesn't support the "noacl" command line option
build/rpm/xfstests.spec.in | 2 +-
check | 3 +-
common/config | 15 ++++++--
common/rc | 69 ++++++++++++++++++++++++++++++++----
doc/requirement-checking.txt | 23 ++++++++++++
tests/generic/123 | 1 +
tests/generic/128 | 1 +
tests/generic/314 | 1 +
tests/generic/317 | 1 +
tests/generic/531 | 1 +
tests/generic/696 | 5 ++-
11 files changed, 110 insertions(+), 12 deletions(-)
next reply other threads:[~2023-04-24 14:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 14:10 David Howells [this message]
2023-04-24 14:10 ` [PATCH v2 1/6] Add AFS support David Howells
2023-04-26 14:30 ` Zorro Lang
2023-04-26 15:53 ` David Howells
2023-04-26 19:40 ` Zorro Lang
2023-04-26 20:32 ` David Howells
2023-04-27 5:38 ` Zorro Lang
2023-04-24 14:10 ` [PATCH v2 2/6] generic/314, afs: Allow for a filesystem that doesn't honour SGID inheritance David Howells
2023-04-26 14:35 ` Zorro Lang
2023-04-24 14:10 ` [PATCH v2 3/6] generic/317, afs: Allow for a filesystem not to honour the local uid/gid David Howells
2023-04-26 14:40 ` Zorro Lang
2023-04-26 15:54 ` David Howells
2023-04-24 14:10 ` [PATCH v2 4/6] generic/123, generic/128, afs: Allow for an fs that does its own perm management David Howells
2023-04-26 14:47 ` Zorro Lang
2023-04-24 14:10 ` [PATCH v2 5/6] generic/531: Check for O_TMPFILE David Howells
2023-04-26 14:49 ` Zorro Lang
2023-04-26 14:51 ` Zorro Lang
2023-04-26 14:54 ` Darrick J. Wong
2023-04-26 15:32 ` Zorro Lang
2023-04-26 15:57 ` David Howells
2023-04-24 14:10 ` [PATCH v2 6/6] generic/696: AFS doesn't support the "noacl" command line option David Howells
2023-04-26 14:53 ` Zorro Lang
2023-04-28 20:06 ` [PATCH v2 7/6] Doc changes for afs David Howells
2023-04-30 6:12 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424141042.450535-1-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=jaltman@auristor.com \
--cc=linux-afs@lists.infradead.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox