FS/XFS testing framework
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: fstests@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
	"Darrick J. Wong" <djwong@kernel.org>, Eryu Guan <guan@eryu.me>,
	Marc Dionne <marc.dionne@auristor.com>,
	Jeffrey Altman <jaltman@auristor.com>,
	linux-afs@lists.infradead.org
Subject: [PATCH v2 6/6] generic/696: AFS doesn't support the "noacl" command line option
Date: Mon, 24 Apr 2023 15:10:42 +0100	[thread overview]
Message-ID: <20230424141042.450535-7-dhowells@redhat.com> (raw)
In-Reply-To: <20230424141042.450535-1-dhowells@redhat.com>

AFS doesn't support the "noacl" command line option.  ACLs are mandatory
and interpreted by the server.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
---
 tests/generic/696 | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/generic/696 b/tests/generic/696
index 178d78e1..55a2fd5a 100755
--- a/tests/generic/696
+++ b/tests/generic/696
@@ -31,7 +31,10 @@ _scratch_mkfs >$seqres.full 2>&1
 $here/src/vfs/vfstest --test-setgid-create-umask \
         --device "$TEST_DEV" --mount "$TEST_DIR" --fstype "$FSTYP"
 
-export MOUNT_OPTIONS="-o noacl $MOUNT_OPTIONS"
+if [ "$FSTYP" != afs ]
+then
+    export MOUNT_OPTIONS="-o noacl $MOUNT_OPTIONS"
+fi
 
 # Also test S_ISGID stripping whether works correctly on underflying filesystem
 # that supports noacl feature.


  parent reply	other threads:[~2023-04-24 14:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 14:10 [PATCH v2 0/6] xfstests: Add support for using xfstests to test AFS David Howells
2023-04-24 14:10 ` [PATCH v2 1/6] Add AFS support David Howells
2023-04-26 14:30   ` Zorro Lang
2023-04-26 15:53     ` David Howells
2023-04-26 19:40       ` Zorro Lang
2023-04-26 20:32         ` David Howells
2023-04-27  5:38           ` Zorro Lang
2023-04-24 14:10 ` [PATCH v2 2/6] generic/314, afs: Allow for a filesystem that doesn't honour SGID inheritance David Howells
2023-04-26 14:35   ` Zorro Lang
2023-04-24 14:10 ` [PATCH v2 3/6] generic/317, afs: Allow for a filesystem not to honour the local uid/gid David Howells
2023-04-26 14:40   ` Zorro Lang
2023-04-26 15:54     ` David Howells
2023-04-24 14:10 ` [PATCH v2 4/6] generic/123, generic/128, afs: Allow for an fs that does its own perm management David Howells
2023-04-26 14:47   ` Zorro Lang
2023-04-24 14:10 ` [PATCH v2 5/6] generic/531: Check for O_TMPFILE David Howells
2023-04-26 14:49   ` Zorro Lang
2023-04-26 14:51     ` Zorro Lang
2023-04-26 14:54       ` Darrick J. Wong
2023-04-26 15:32         ` Zorro Lang
2023-04-26 15:57       ` David Howells
2023-04-24 14:10 ` David Howells [this message]
2023-04-26 14:53   ` [PATCH v2 6/6] generic/696: AFS doesn't support the "noacl" command line option Zorro Lang
2023-04-28 20:06 ` [PATCH v2 7/6] Doc changes for afs David Howells
2023-04-30  6:12   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230424141042.450535-7-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=jaltman@auristor.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=marc.dionne@auristor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox