From: David Howells <dhowells@redhat.com>
To: fstests@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>, Eryu Guan <guan@eryu.me>,
Marc Dionne <marc.dionne@auristor.com>,
Jeffrey Altman <jaltman@auristor.com>,
linux-afs@lists.infradead.org
Subject: [PATCH v2 3/6] generic/317, afs: Allow for a filesystem not to honour the local uid/gid
Date: Mon, 24 Apr 2023 15:10:39 +0100 [thread overview]
Message-ID: <20230424141042.450535-4-dhowells@redhat.com> (raw)
In-Reply-To: <20230424141042.450535-1-dhowells@redhat.com>
Each AFS cell has it's own set of user IDs that is uses internally, in its
ACL system and in its protection management protocol. The user ID used by
the fileserver is selected from the set belonging to the fileserver's cell
according to the authentication token associated with an RPC operation -
and this is set as a file's user ID when it is created.
This means that tests that expect to set a UID and see the same UID still
set afterwards will fail.
Add a "_require_use_local_uidgid" clause to indicate that a test expects
internal UID/GID information to be seen in the stat output and should be
skipped if AFS's case.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
---
common/rc | 9 +++++++++
doc/requirement-checking.txt | 8 ++++++++
tests/generic/317 | 1 +
3 files changed, 18 insertions(+)
diff --git a/common/rc b/common/rc
index 00c5fcfe..e0978a03 100644
--- a/common/rc
+++ b/common/rc
@@ -5106,6 +5106,15 @@ _require_sgid_inheritance()
esac
}
+_require_use_local_uidgid()
+{
+ case $FSTYP in
+ afs)
+ _notrun "$FSTYP doesn't honour local uid and gid"
+ ;;
+ esac
+}
+
init_rc
################################################################################
diff --git a/doc/requirement-checking.txt b/doc/requirement-checking.txt
index a3588ee9..f24ecf5c 100644
--- a/doc/requirement-checking.txt
+++ b/doc/requirement-checking.txt
@@ -17,6 +17,7 @@ they have. This is done with _require_<xxx> macros, which may take parameters.
_require_chattr <letters>
_require_exportfs
_require_sgid_inheritance
+ _require_use_local_uidgid
(3) System call requirements.
@@ -104,6 +105,13 @@ _require_sgid_inheritance
of the SGID bit and the GID from a marked directory. The test will be
skipped if not supported.
+_require_use_local_uidgid
+
+ The test requires that the $TEST_DEV filesystem sets the uid and gid of a
+ newly created file to the creating process's fsuid and fsgid. Remote
+ filesystems, for example, may choose other settings or not even have these
+ concepts available. The test will be skipped if not supported.
+
========================
SYSTEM CALL REQUIREMENTS
diff --git a/tests/generic/317 b/tests/generic/317
index 134d5e3f..39cccc8b 100755
--- a/tests/generic/317
+++ b/tests/generic/317
@@ -38,6 +38,7 @@ _require_user
_require_ugid_map
_require_userns
_require_chown
+_require_use_local_uidgid
qa_user_id=`id -u $qa_user`
_filter_output()
next prev parent reply other threads:[~2023-04-24 14:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 14:10 [PATCH v2 0/6] xfstests: Add support for using xfstests to test AFS David Howells
2023-04-24 14:10 ` [PATCH v2 1/6] Add AFS support David Howells
2023-04-26 14:30 ` Zorro Lang
2023-04-26 15:53 ` David Howells
2023-04-26 19:40 ` Zorro Lang
2023-04-26 20:32 ` David Howells
2023-04-27 5:38 ` Zorro Lang
2023-04-24 14:10 ` [PATCH v2 2/6] generic/314, afs: Allow for a filesystem that doesn't honour SGID inheritance David Howells
2023-04-26 14:35 ` Zorro Lang
2023-04-24 14:10 ` David Howells [this message]
2023-04-26 14:40 ` [PATCH v2 3/6] generic/317, afs: Allow for a filesystem not to honour the local uid/gid Zorro Lang
2023-04-26 15:54 ` David Howells
2023-04-24 14:10 ` [PATCH v2 4/6] generic/123, generic/128, afs: Allow for an fs that does its own perm management David Howells
2023-04-26 14:47 ` Zorro Lang
2023-04-24 14:10 ` [PATCH v2 5/6] generic/531: Check for O_TMPFILE David Howells
2023-04-26 14:49 ` Zorro Lang
2023-04-26 14:51 ` Zorro Lang
2023-04-26 14:54 ` Darrick J. Wong
2023-04-26 15:32 ` Zorro Lang
2023-04-26 15:57 ` David Howells
2023-04-24 14:10 ` [PATCH v2 6/6] generic/696: AFS doesn't support the "noacl" command line option David Howells
2023-04-26 14:53 ` Zorro Lang
2023-04-28 20:06 ` [PATCH v2 7/6] Doc changes for afs David Howells
2023-04-30 6:12 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424141042.450535-4-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=jaltman@auristor.com \
--cc=linux-afs@lists.infradead.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox