FS/XFS testing framework
 help / color / mirror / Atom feed
* [PATCH] fsx: Add a return type to aio_rw
@ 2023-09-27 13:16 Vyacheslav Yurkov
  2023-09-27 14:30 ` Darrick J. Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Vyacheslav Yurkov @ 2023-09-27 13:16 UTC (permalink / raw)
  To: fstests; +Cc: Khem Raj, Vyacheslav Yurkov, Darrick J . Wong, Zorro Lang

From: Khem Raj <raj.khem@gmail.com>

Compilers complain about the function prototype otherwise

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
Cc: Darrick J. Wong <djwong@kernel.org>
Cc: Zorro Lang <zlang@redhat.com>
---
 ltp/fsx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ltp/fsx.c b/ltp/fsx.c
index ccb382e7..a30e2a8d 100644
--- a/ltp/fsx.c
+++ b/ltp/fsx.c
@@ -2592,6 +2592,7 @@ out_error:
 	return -1;
 }
 #else
+int
 aio_rw(int rw, int fd, char *buf, unsigned len, unsigned offset)
 {
 	fprintf(stderr, "io_rw: need AIO support!\n");
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fsx: Add a return type to aio_rw
  2023-09-27 13:16 [PATCH] fsx: Add a return type to aio_rw Vyacheslav Yurkov
@ 2023-09-27 14:30 ` Darrick J. Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2023-09-27 14:30 UTC (permalink / raw)
  To: Vyacheslav Yurkov; +Cc: fstests, Khem Raj, Zorro Lang

On Wed, Sep 27, 2023 at 03:16:17PM +0200, Vyacheslav Yurkov wrote:
> From: Khem Raj <raj.khem@gmail.com>
> 
> Compilers complain about the function prototype otherwise
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: Zorro Lang <zlang@redhat.com>

Whoooops, good catch!
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  ltp/fsx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ltp/fsx.c b/ltp/fsx.c
> index ccb382e7..a30e2a8d 100644
> --- a/ltp/fsx.c
> +++ b/ltp/fsx.c
> @@ -2592,6 +2592,7 @@ out_error:
>  	return -1;
>  }
>  #else
> +int
>  aio_rw(int rw, int fd, char *buf, unsigned len, unsigned offset)
>  {
>  	fprintf(stderr, "io_rw: need AIO support!\n");
> -- 
> 2.35.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-27 14:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 13:16 [PATCH] fsx: Add a return type to aio_rw Vyacheslav Yurkov
2023-09-27 14:30 ` Darrick J. Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox