* [PATCH] common/config: Correctly ignore {TEST|SCRATCH}_DEV for tmpfs
@ 2024-08-21 15:57 André Almeida
2024-08-21 17:12 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: André Almeida @ 2024-08-21 15:57 UTC (permalink / raw)
To: fstests
Cc: Zorro Lang, kernel-dev, Miklos Szeredi, Eryu Guan,
André Almeida
As per commit 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV"),
tmpfs doesn't need TEST or SCRATCH devices due to being a RAM-based
filesystem.
Fix the check by comparing the content of the variable TEST_DEV, instead
of comparing with the string TEST_DEV. Same for SCRATCH_DEV.
Fixes: 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV")
Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
common/config | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/config b/common/config
index 22740c0a..307f93fb 100644
--- a/common/config
+++ b/common/config
@@ -829,10 +829,10 @@ get_next_config() {
fi
if [ "$FSTYP" == "tmpfs" ]; then
- if [ -z "TEST_DEV" ]; then
+ if [ -z "$TEST_DEV" ]; then
export TEST_DEV=tmpfs_test
fi
- if [ -z "SCRATCH_DEV" ]; then
+ if [ -z "$SCRATCH_DEV" ]; then
export TEST_DEV=tmpfs_scratch
fi
fi
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] common/config: Correctly ignore {TEST|SCRATCH}_DEV for tmpfs
2024-08-21 15:57 [PATCH] common/config: Correctly ignore {TEST|SCRATCH}_DEV for tmpfs André Almeida
@ 2024-08-21 17:12 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2024-08-21 17:12 UTC (permalink / raw)
To: André Almeida
Cc: fstests, Zorro Lang, kernel-dev, Miklos Szeredi, Eryu Guan
On Wed, Aug 21, 2024 at 12:57:46PM -0300, André Almeida wrote:
> As per commit 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV"),
> tmpfs doesn't need TEST or SCRATCH devices due to being a RAM-based
> filesystem.
>
> Fix the check by comparing the content of the variable TEST_DEV, instead
> of comparing with the string TEST_DEV. Same for SCRATCH_DEV.
>
> Fixes: 264e5358e2c2 ("tmpfs: don't require {TEST|SCRATCH}_DEV")
> Signed-off-by: André Almeida <andrealmeid@igalia.com>
Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> common/config | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/config b/common/config
> index 22740c0a..307f93fb 100644
> --- a/common/config
> +++ b/common/config
> @@ -829,10 +829,10 @@ get_next_config() {
> fi
>
> if [ "$FSTYP" == "tmpfs" ]; then
> - if [ -z "TEST_DEV" ]; then
> + if [ -z "$TEST_DEV" ]; then
> export TEST_DEV=tmpfs_test
> fi
> - if [ -z "SCRATCH_DEV" ]; then
> + if [ -z "$SCRATCH_DEV" ]; then
> export TEST_DEV=tmpfs_scratch
> fi
> fi
> --
> 2.46.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-21 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-21 15:57 [PATCH] common/config: Correctly ignore {TEST|SCRATCH}_DEV for tmpfs André Almeida
2024-08-21 17:12 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox