* [PATCH] generic/375: clarify flipping the write bit
@ 2024-08-01 23:04 Matthew Broomfield
2024-09-14 20:18 ` Matthew Broomfield
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Broomfield @ 2024-08-01 23:04 UTC (permalink / raw)
To: Zorro Lang; +Cc: Matthew Broomfield, fstests
When checking if SGID is cleared upon chmod / setfacl the write bit is
flipped just to make sure permission changes are happening. This is
orthogonal to testing SGID.
Added this information to the test description.
Signed-off-by: Matthew Broomfield <mattysweeps@google.com>
---
tests/generic/375 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/generic/375 b/tests/generic/375
index eb675144..44670350 100755
--- a/tests/generic/375
+++ b/tests/generic/375
@@ -7,6 +7,9 @@
# Check if SGID is cleared upon chmod / setfacl when the owner is not in the
# owning group.
#
+# The test flips the write bit to easily observe that chmod / setfacl are
+# successful. This is unrelated to testing SGID.
+#
. ./common/preamble
_begin_fstest auto quick acl perms
--
2.46.0.rc2.264.g509ed76dc8-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] generic/375: clarify flipping the write bit
2024-08-01 23:04 [PATCH] generic/375: clarify flipping the write bit Matthew Broomfield
@ 2024-09-14 20:18 ` Matthew Broomfield
2024-09-16 21:18 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Broomfield @ 2024-09-14 20:18 UTC (permalink / raw)
To: Zorro Lang; +Cc: fstests
On Thu, Aug 1, 2024 at 4:04 PM Matthew Broomfield
<mattysweeps@google.com> wrote:
>
> When checking if SGID is cleared upon chmod / setfacl the write bit is
> flipped just to make sure permission changes are happening. This is
> orthogonal to testing SGID.
>
> Added this information to the test description.
>
> Signed-off-by: Matthew Broomfield <mattysweeps@google.com>
> ---
> tests/generic/375 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/generic/375 b/tests/generic/375
> index eb675144..44670350 100755
> --- a/tests/generic/375
> +++ b/tests/generic/375
> @@ -7,6 +7,9 @@
> # Check if SGID is cleared upon chmod / setfacl when the owner is not in the
> # owning group.
> #
> +# The test flips the write bit to easily observe that chmod / setfacl are
> +# successful. This is unrelated to testing SGID.
> +#
> . ./common/preamble
> _begin_fstest auto quick acl perms
>
> --
> 2.46.0.rc2.264.g509ed76dc8-goog
>
Hello, can someone review if the comment in this patch is accurate?
Thanks in advance for your time.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] generic/375: clarify flipping the write bit
2024-09-14 20:18 ` Matthew Broomfield
@ 2024-09-16 21:18 ` Darrick J. Wong
0 siblings, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2024-09-16 21:18 UTC (permalink / raw)
To: Matthew Broomfield; +Cc: Zorro Lang, fstests
On Sat, Sep 14, 2024 at 01:18:03PM -0700, Matthew Broomfield wrote:
> On Thu, Aug 1, 2024 at 4:04 PM Matthew Broomfield
> <mattysweeps@google.com> wrote:
> >
> > When checking if SGID is cleared upon chmod / setfacl the write bit is
> > flipped just to make sure permission changes are happening. This is
> > orthogonal to testing SGID.
> >
> > Added this information to the test description.
> >
> > Signed-off-by: Matthew Broomfield <mattysweeps@google.com>
> > ---
> > tests/generic/375 | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/generic/375 b/tests/generic/375
> > index eb675144..44670350 100755
> > --- a/tests/generic/375
> > +++ b/tests/generic/375
> > @@ -7,6 +7,9 @@
> > # Check if SGID is cleared upon chmod / setfacl when the owner is not in the
> > # owning group.
> > #
> > +# The test flips the write bit to easily observe that chmod / setfacl are
> > +# successful. This is unrelated to testing SGID.
> > +#
> > . ./common/preamble
> > _begin_fstest auto quick acl perms
> >
> > --
> > 2.46.0.rc2.264.g509ed76dc8-goog
> >
>
> Hello, can someone review if the comment in this patch is accurate?
> Thanks in advance for your time.
I don't understand this new comment -- "flipping the write bit" is what
the chmod does, and that's what clears setgid.
--D
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-16 21:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 23:04 [PATCH] generic/375: clarify flipping the write bit Matthew Broomfield
2024-09-14 20:18 ` Matthew Broomfield
2024-09-16 21:18 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox