* [PATCH] xfs/32: fix test failure on kernels which don't support bs > ps
@ 2025-01-17 19:06 Theodore Ts'o
2025-01-17 21:02 ` Darrick J. Wong
0 siblings, 1 reply; 7+ messages in thread
From: Theodore Ts'o @ 2025-01-17 19:06 UTC (permalink / raw)
To: fstests; +Cc: Theodore Ts'o
When trying to mount a file system with a block size > page size on
kernel which doesn't support this, suppress the error messages from
showing up in the output file lest it cause test failures.
Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
tests/xfs/032 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/032 b/tests/xfs/032
index 41a9134d8..9c1741cf1 100755
--- a/tests/xfs/032
+++ b/tests/xfs/032
@@ -44,7 +44,7 @@ for ((; SECTORSIZE <= 65536; SECTORSIZE *= 2)); do
if [ $? -ne 0 ]; then
continue
fi
- if ! _try_scratch_mount; then
+ if ! _try_scratch_mount >& /dev/null ; then
if [ $BLOCKSIZE -le $PAGESIZE ]; then
_fail "mount $(_scratch_mount_options $*) failed"
fi
--
2.45.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] xfs/32: fix test failure on kernels which don't support bs > ps
2025-01-17 19:06 [PATCH] xfs/32: fix test failure on kernels which don't support bs > ps Theodore Ts'o
@ 2025-01-17 21:02 ` Darrick J. Wong
2025-01-20 17:01 ` [PATCH -v2] " Theodore Ts'o
0 siblings, 1 reply; 7+ messages in thread
From: Darrick J. Wong @ 2025-01-17 21:02 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests
On Fri, Jan 17, 2025 at 02:06:59PM -0500, Theodore Ts'o wrote:
> When trying to mount a file system with a block size > page size on
> kernel which doesn't support this, suppress the error messages from
> showing up in the output file lest it cause test failures.
>
> Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> tests/xfs/032 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/032 b/tests/xfs/032
> index 41a9134d8..9c1741cf1 100755
> --- a/tests/xfs/032
> +++ b/tests/xfs/032
> @@ -44,7 +44,7 @@ for ((; SECTORSIZE <= 65536; SECTORSIZE *= 2)); do
> if [ $? -ne 0 ]; then
> continue
> fi
> - if ! _try_scratch_mount; then
> + if ! _try_scratch_mount >& /dev/null ; then
Should we dump that to $seqres.full instead of discarding it?
--D
> if [ $BLOCKSIZE -le $PAGESIZE ]; then
> _fail "mount $(_scratch_mount_options $*) failed"
> fi
> --
> 2.45.2
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH -v2] xfs/32: fix test failure on kernels which don't support bs > ps
2025-01-17 21:02 ` Darrick J. Wong
@ 2025-01-20 17:01 ` Theodore Ts'o
2025-01-21 2:35 ` Zorro Lang
2025-01-21 15:59 ` Darrick J. Wong
0 siblings, 2 replies; 7+ messages in thread
From: Theodore Ts'o @ 2025-01-20 17:01 UTC (permalink / raw)
To: fstests; +Cc: Darrick J. Wong, Theodore Ts'o
When trying to mount a file system with a block size > page size on
kernel which doesn't support this, suppress the error messages from
showing up in the output file lest it cause test failures.
Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
v2:
As Darrick suggested redirect the output of mount(8) to $seqres.full
instead of /dev/null
tests/xfs/032 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/032 b/tests/xfs/032
index 41a9134d8..675881d5b 100755
--- a/tests/xfs/032
+++ b/tests/xfs/032
@@ -44,7 +44,7 @@ for ((; SECTORSIZE <= 65536; SECTORSIZE *= 2)); do
if [ $? -ne 0 ]; then
continue
fi
- if ! _try_scratch_mount; then
+ if ! _try_scratch_mount >> $seqres.full 2>&1 ; then
if [ $BLOCKSIZE -le $PAGESIZE ]; then
_fail "mount $(_scratch_mount_options $*) failed"
fi
--
2.45.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH -v2] xfs/32: fix test failure on kernels which don't support bs > ps
2025-01-20 17:01 ` [PATCH -v2] " Theodore Ts'o
@ 2025-01-21 2:35 ` Zorro Lang
2025-01-21 3:33 ` Theodore Ts'o
2025-01-21 15:59 ` Darrick J. Wong
1 sibling, 1 reply; 7+ messages in thread
From: Zorro Lang @ 2025-01-21 2:35 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests, Darrick J. Wong
On Mon, Jan 20, 2025 at 12:01:09PM -0500, Theodore Ts'o wrote:
> When trying to mount a file system with a block size > page size on
> kernel which doesn't support this, suppress the error messages from
> showing up in the output file lest it cause test failures.
>
> Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> v2:
> As Darrick suggested redirect the output of mount(8) to $seqres.full
> instead of /dev/null
Thanks for fixing it.
Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> tests/xfs/032 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/032 b/tests/xfs/032
> index 41a9134d8..675881d5b 100755
> --- a/tests/xfs/032
> +++ b/tests/xfs/032
> @@ -44,7 +44,7 @@ for ((; SECTORSIZE <= 65536; SECTORSIZE *= 2)); do
> if [ $? -ne 0 ]; then
> continue
> fi
> - if ! _try_scratch_mount; then
> + if ! _try_scratch_mount >> $seqres.full 2>&1 ; then
> if [ $BLOCKSIZE -le $PAGESIZE ]; then
> _fail "mount $(_scratch_mount_options $*) failed"
> fi
> --
> 2.45.2
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH -v2] xfs/32: fix test failure on kernels which don't support bs > ps
2025-01-21 2:35 ` Zorro Lang
@ 2025-01-21 3:33 ` Theodore Ts'o
2025-01-21 5:12 ` Zorro Lang
0 siblings, 1 reply; 7+ messages in thread
From: Theodore Ts'o @ 2025-01-21 3:33 UTC (permalink / raw)
To: Zorro Lang; +Cc: fstests, Darrick J. Wong
On Tue, Jan 21, 2025 at 10:35:36AM +0800, Zorro Lang wrote:
> On Mon, Jan 20, 2025 at 12:01:09PM -0500, Theodore Ts'o wrote:
> > When trying to mount a file system with a block size > page size on
> > kernel which doesn't support this, suppress the error messages from
> > showing up in the output file lest it cause test failures.
> >
> > Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > ---
> > v2:
> > As Darrick suggested redirect the output of mount(8) to $seqres.full
> > instead of /dev/null
>
> Thanks for fixing it.
>
> Reviewed-by: Zorro Lang <zlang@redhat.com>
I just noticed just now that I screwed up the subject line / commit description.
xfs/32: ...
should be:
xfs/032: ...
Sorry for not noticing this earlier!
- Ted
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH -v2] xfs/32: fix test failure on kernels which don't support bs > ps
2025-01-21 3:33 ` Theodore Ts'o
@ 2025-01-21 5:12 ` Zorro Lang
0 siblings, 0 replies; 7+ messages in thread
From: Zorro Lang @ 2025-01-21 5:12 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests, Darrick J. Wong
On Mon, Jan 20, 2025 at 10:33:56PM -0500, Theodore Ts'o wrote:
> On Tue, Jan 21, 2025 at 10:35:36AM +0800, Zorro Lang wrote:
> > On Mon, Jan 20, 2025 at 12:01:09PM -0500, Theodore Ts'o wrote:
> > > When trying to mount a file system with a block size > page size on
> > > kernel which doesn't support this, suppress the error messages from
> > > showing up in the output file lest it cause test failures.
> > >
> > > Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
> > > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > > ---
> > > v2:
> > > As Darrick suggested redirect the output of mount(8) to $seqres.full
> > > instead of /dev/null
> >
> > Thanks for fixing it.
> >
> > Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> I just noticed just now that I screwed up the subject line / commit description.
>
> xfs/32: ...
>
> should be:
>
> xfs/032: ...
>
> Sorry for not noticing this earlier!
Never mind, I've changed that when I merge it :)
>
> - Ted
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -v2] xfs/32: fix test failure on kernels which don't support bs > ps
2025-01-20 17:01 ` [PATCH -v2] " Theodore Ts'o
2025-01-21 2:35 ` Zorro Lang
@ 2025-01-21 15:59 ` Darrick J. Wong
1 sibling, 0 replies; 7+ messages in thread
From: Darrick J. Wong @ 2025-01-21 15:59 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests
On Mon, Jan 20, 2025 at 12:01:09PM -0500, Theodore Ts'o wrote:
> When trying to mount a file system with a block size > page size on
> kernel which doesn't support this, suppress the error messages from
> showing up in the output file lest it cause test failures.
>
> Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> v2:
> As Darrick suggested redirect the output of mount(8) to $seqres.full
> instead of /dev/null
>
> tests/xfs/032 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/032 b/tests/xfs/032
> index 41a9134d8..675881d5b 100755
> --- a/tests/xfs/032
> +++ b/tests/xfs/032
> @@ -44,7 +44,7 @@ for ((; SECTORSIZE <= 65536; SECTORSIZE *= 2)); do
> if [ $? -ne 0 ]; then
> continue
> fi
> - if ! _try_scratch_mount; then
> + if ! _try_scratch_mount >> $seqres.full 2>&1 ; then
> if [ $BLOCKSIZE -le $PAGESIZE ]; then
> _fail "mount $(_scratch_mount_options $*) failed"
> fi
> --
> 2.45.2
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-01-21 15:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-17 19:06 [PATCH] xfs/32: fix test failure on kernels which don't support bs > ps Theodore Ts'o
2025-01-17 21:02 ` Darrick J. Wong
2025-01-20 17:01 ` [PATCH -v2] " Theodore Ts'o
2025-01-21 2:35 ` Zorro Lang
2025-01-21 3:33 ` Theodore Ts'o
2025-01-21 5:12 ` Zorro Lang
2025-01-21 15:59 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox