[PATCH] common: log mkfs output in _test_streams

[PATCH] common: log mkfs output in _test_streams

[Christoph Hellwig]

Log the mkfs output to allow debugging the mkfs paramters,
especially when mkfs and thus the test fails.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 common/filestreams | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/filestreams b/common/filestreams
index 459de8c6b6a6..0b11b6644977 100644
--- a/common/filestreams
+++ b/common/filestreams
@@ -89,7 +89,7 @@ _test_streams() {
 	# Skip these tests on zoned file systems as filestreams don't work
 	# with the zoned allocator, and the operation below would force it into
 	# the tiny data section only used for metadata anyway.
-	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+	_try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"
 	_scratch_mount
 	_require_xfs_scratch_non_zoned
 	_scratch_unmount 2>/dev/null
-- 
2.53.0

Re: [PATCH] common: log mkfs output in _test_streams

[Darrick J. Wong]

On Tue, Jun 30, 2026 at 08:20:47AM -0600, Christoph Hellwig wrote:
> Log the mkfs output to allow debugging the mkfs paramters,
> especially when mkfs and thus the test fails.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  common/filestreams | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/filestreams b/common/filestreams
> index 459de8c6b6a6..0b11b6644977 100644
> --- a/common/filestreams
> +++ b/common/filestreams
> @@ -89,7 +89,7 @@ _test_streams() {
>  	# Skip these tests on zoned file systems as filestreams don't work
>  	# with the zoned allocator, and the operation below would force it into
>  	# the tiny data section only used for metadata anyway.
> -	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
> +	_try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"

This should >>$seqres.full so that you don't obliterate whatever might
already be in that file.  Otherwise this sounds like a good idea to me.

--D

>  	_scratch_mount
>  	_require_xfs_scratch_non_zoned
>  	_scratch_unmount 2>/dev/null
> -- 
> 2.53.0
> 
> 

Re: [PATCH] common: log mkfs output in _test_streams

[Christoph Hellwig]

On Tue, Jun 30, 2026 at 12:13:03PM -0700, Darrick J. Wong wrote:
> On Tue, Jun 30, 2026 at 08:20:47AM -0600, Christoph Hellwig wrote:
> > Log the mkfs output to allow debugging the mkfs paramters,
> > especially when mkfs and thus the test fails.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> >  common/filestreams | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/common/filestreams b/common/filestreams
> > index 459de8c6b6a6..0b11b6644977 100644
> > --- a/common/filestreams
> > +++ b/common/filestreams
> > @@ -89,7 +89,7 @@ _test_streams() {
> >  	# Skip these tests on zoned file systems as filestreams don't work
> >  	# with the zoned allocator, and the operation below would force it into
> >  	# the tiny data section only used for metadata anyway.
> > -	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
> > +	_try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"
> 
> This should >>$seqres.full so that you don't obliterate whatever might
> already be in that file.  Otherwise this sounds like a good idea to me.

Oh, right..