* [PATCH] common: log mkfs output in _test_streams
@ 2026-06-30 14:20 Christoph Hellwig
2026-06-30 19:13 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2026-06-30 14:20 UTC (permalink / raw)
To: zlang; +Cc: fstests
Log the mkfs output to allow debugging the mkfs paramters,
especially when mkfs and thus the test fails.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
common/filestreams | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/filestreams b/common/filestreams
index 459de8c6b6a6..0b11b6644977 100644
--- a/common/filestreams
+++ b/common/filestreams
@@ -89,7 +89,7 @@ _test_streams() {
# Skip these tests on zoned file systems as filestreams don't work
# with the zoned allocator, and the operation below would force it into
# the tiny data section only used for metadata anyway.
- _try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+ _try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"
_scratch_mount
_require_xfs_scratch_non_zoned
_scratch_unmount 2>/dev/null
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] common: log mkfs output in _test_streams
2026-06-30 14:20 [PATCH] common: log mkfs output in _test_streams Christoph Hellwig
@ 2026-06-30 19:13 ` Darrick J. Wong
2026-07-01 10:50 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2026-06-30 19:13 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: zlang, fstests
On Tue, Jun 30, 2026 at 08:20:47AM -0600, Christoph Hellwig wrote:
> Log the mkfs output to allow debugging the mkfs paramters,
> especially when mkfs and thus the test fails.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> common/filestreams | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/filestreams b/common/filestreams
> index 459de8c6b6a6..0b11b6644977 100644
> --- a/common/filestreams
> +++ b/common/filestreams
> @@ -89,7 +89,7 @@ _test_streams() {
> # Skip these tests on zoned file systems as filestreams don't work
> # with the zoned allocator, and the operation below would force it into
> # the tiny data section only used for metadata anyway.
> - _try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
> + _try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"
This should >>$seqres.full so that you don't obliterate whatever might
already be in that file. Otherwise this sounds like a good idea to me.
--D
> _scratch_mount
> _require_xfs_scratch_non_zoned
> _scratch_unmount 2>/dev/null
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] common: log mkfs output in _test_streams
2026-06-30 19:13 ` Darrick J. Wong
@ 2026-07-01 10:50 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2026-07-01 10:50 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Christoph Hellwig, zlang, fstests
On Tue, Jun 30, 2026 at 12:13:03PM -0700, Darrick J. Wong wrote:
> On Tue, Jun 30, 2026 at 08:20:47AM -0600, Christoph Hellwig wrote:
> > Log the mkfs output to allow debugging the mkfs paramters,
> > especially when mkfs and thus the test fails.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > common/filestreams | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/common/filestreams b/common/filestreams
> > index 459de8c6b6a6..0b11b6644977 100644
> > --- a/common/filestreams
> > +++ b/common/filestreams
> > @@ -89,7 +89,7 @@ _test_streams() {
> > # Skip these tests on zoned file systems as filestreams don't work
> > # with the zoned allocator, and the operation below would force it into
> > # the tiny data section only used for metadata anyway.
> > - _try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
> > + _try_scratch_mkfs_xfs >$seqres.full 2>&1 || _fail "mkfs failed"
>
> This should >>$seqres.full so that you don't obliterate whatever might
> already be in that file. Otherwise this sounds like a good idea to me.
Oh, right..
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-01 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-30 14:20 [PATCH] common: log mkfs output in _test_streams Christoph Hellwig
2026-06-30 19:13 ` Darrick J. Wong
2026-07-01 10:50 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox