From: Ojaswin Mujoo <ojaswin@linux.ibm.com>
To: Zorro Lang <zlang@redhat.com>, fstests@vger.kernel.org
Cc: Ritesh Harjani <ritesh.list@gmail.com>,
djwong@kernel.org, john.g.garry@oracle.com, tytso@mit.edu,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: [PATCH v5 07/12] generic: Add atomic write multi-fsblock O_[D]SYNC tests
Date: Fri, 22 Aug 2025 13:32:06 +0530 [thread overview]
Message-ID: <55583acdfb6cb69bcea84a56cbc20754e1d2f4f4.1755849134.git.ojaswin@linux.ibm.com> (raw)
In-Reply-To: <cover.1755849134.git.ojaswin@linux.ibm.com>
This adds various atomic write multi-fsblock stresst tests
with mixed mappings and O_SYNC, to ensure the data and metadata
is atomically persisted even if there is a shutdown.
Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
---
tests/generic/1228 | 137 +++++++++++++++++++++++++++++++++++++++++
tests/generic/1228.out | 2 +
2 files changed, 139 insertions(+)
create mode 100755 tests/generic/1228
create mode 100644 tests/generic/1228.out
diff --git a/tests/generic/1228 b/tests/generic/1228
new file mode 100755
index 00000000..888599ce
--- /dev/null
+++ b/tests/generic/1228
@@ -0,0 +1,137 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 IBM Corporation. All Rights Reserved.
+#
+# FS QA Test 1228
+#
+# Atomic write multi-fsblock data integrity tests with mixed mappings
+# and O_SYNC
+#
+. ./common/preamble
+. ./common/atomicwrites
+_begin_fstest auto quick rw atomicwrites
+
+_require_scratch_write_atomic_multi_fsblock
+_require_atomic_write_test_commands
+_require_scratch_shutdown
+_require_xfs_io_command "truncate"
+
+_scratch_mkfs >> $seqres.full
+_scratch_mount >> $seqres.full
+
+check_data_integrity() {
+ actual=$(_hexdump $testfile)
+ if [[ "$expected" != "$actual" ]]
+ then
+ echo "Integrity check failed"
+ echo "Integrity check failed" >> $seqres.full
+ echo "# Expected file contents:" >> $seqres.full
+ echo "$expected" >> $seqres.full
+ echo "# Actual file contents:" >> $seqres.full
+ echo "$actual" >> $seqres.full
+
+ _fail "Data integrity check failed. The atomic write was torn."
+ fi
+}
+
+prep_mixed_mapping() {
+ $XFS_IO_PROG -c "truncate 0" $testfile >> $seqres.full
+ local off=0
+ local mapping=""
+
+ local operations=("W" "H" "U")
+ local num_blocks=$((awu_max / blksz))
+ for ((i=0; i<num_blocks; i++)); do
+ local index=$((RANDOM % ${#operations[@]}))
+ local map="${operations[$index]}"
+ local mapping="${mapping}${map}"
+
+ case "$map" in
+ "W")
+ $XFS_IO_PROG -dc "pwrite -S 0x61 -b $blksz $off $blksz" $testfile > /dev/null
+ ;;
+ "H")
+ # No operation needed for hole
+ ;;
+ "U")
+ $XFS_IO_PROG -c "falloc $off $blksz" $testfile >> /dev/null
+ ;;
+ esac
+ off=$((off + blksz))
+ done
+
+ echo "+ + Mixed mapping prep done. Full mapping pattern: $mapping" >> $seqres.full
+
+ sync $testfile
+}
+
+verify_atomic_write() {
+ test $bytes_written -eq $awu_max || _fail "atomic write len=$awu_max assertion failed"
+ check_data_integrity
+}
+
+mixed_mapping_test() {
+ prep_mixed_mapping
+
+ echo -"+ + Performing O_DSYNC atomic write from 0 to $awu_max" >> $seqres.full
+ if [[ "$1" == "shutdown" ]]
+ then
+ bytes_written=$($XFS_IO_PROG -x -dc \
+ "pwrite -DA -V1 -b $awu_max 0 $awu_max" \
+ -c "shutdown" $testfile | grep wrote | \
+ awk -F'[/ ]' '{print $2}')
+ _scratch_cycle_mount >>$seqres.full 2>&1 || _fail "remount failed"
+ else
+ bytes_written=$($XFS_IO_PROG -dc \
+ "pwrite -DA -V1 -b $awu_max 0 $awu_max" $testfile | \
+ grep wrote | awk -F'[/ ]' '{print $2}')
+ fi
+
+ verify_atomic_write
+}
+
+testfile=$SCRATCH_MNT/testfile
+touch $testfile
+
+awu_max=$(_get_atomic_write_unit_max $testfile)
+blksz=$(_get_block_size $SCRATCH_MNT)
+
+# Create an expected pattern to compare with
+$XFS_IO_PROG -tc "pwrite -b $awu_max 0 $awu_max" $testfile >> $seqres.full
+expected=$(_hexdump $testfile)
+echo "# Expected file contents:" >> $seqres.full
+echo "$expected" >> $seqres.full
+echo >> $seqres.full
+
+echo "# Test 1: Do O_DSYNC atomic write on random mixed mapping:" >> $seqres.full
+echo >> $seqres.full
+for ((iteration=1; iteration<=10; iteration++)); do
+ echo "=== Mixed Mapping Test Iteration $iteration ===" >> $seqres.full
+
+ echo "+ Testing without shutdown..." >> $seqres.full
+ mixed_mapping_test
+ echo "Passed!" >> $seqres.full
+
+ echo "+ Testing with sudden shutdown..." >> $seqres.full
+ mixed_mapping_test "shutdown"
+ echo "Passed!" >> $seqres.full
+
+ echo "Iteration $iteration completed: OK" >> $seqres.full
+ echo >> $seqres.full
+done
+echo "# Test 1: Do O_SYNC atomic write on random mixed mapping (10 iterations): OK" >> $seqres.full
+
+
+echo >> $seqres.full
+echo "# Test 2: Do extending O_SYNC atomic writes: " >> $seqres.full
+bytes_written=$($XFS_IO_PROG -x -dstc "pwrite -A -V1 -b $awu_max 0 $awu_max" \
+ -c "shutdown" $testfile | grep wrote | awk -F'[/ ]' '{print $2}')
+_scratch_cycle_mount >>$seqres.full 2>&1 || _fail "remount failed"
+verify_atomic_write
+echo "# Test 2: Do extending O_SYNC atomic writes: OK" >> $seqres.full
+
+# success, all done
+echo "Silence is golden"
+status=0
+exit
+
diff --git a/tests/generic/1228.out b/tests/generic/1228.out
new file mode 100644
index 00000000..1baffa91
--- /dev/null
+++ b/tests/generic/1228.out
@@ -0,0 +1,2 @@
+QA output created by 1228
+Silence is golden
--
2.49.0
next prev parent reply other threads:[~2025-08-22 8:02 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 8:01 [PATCH v5 00/11] Add more tests for multi fs block atomic writes Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 01/12] common/rc: Add _min() and _max() helpers Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 02/12] common/rc: Add _require_fio_version helper Ojaswin Mujoo
2025-08-25 16:08 ` Zorro Lang
2025-08-27 15:16 ` Ojaswin Mujoo
2025-08-28 15:09 ` Darrick J. Wong
2025-08-29 16:59 ` Ojaswin Mujoo
2025-08-30 17:09 ` Zorro Lang
2025-09-01 11:40 ` Ojaswin Mujoo
2025-09-02 5:30 ` Zorro Lang
2025-09-02 8:29 ` John Garry
2025-09-02 14:50 ` John Garry
2025-09-05 15:51 ` Ojaswin Mujoo
2025-09-05 16:14 ` John Garry
2025-09-05 16:39 ` Ojaswin Mujoo
2025-09-07 5:18 ` Zorro Lang
2025-09-07 5:29 ` Zorro Lang
2025-09-09 7:16 ` Ojaswin Mujoo
2025-09-09 7:26 ` John Garry
2025-09-09 9:02 ` Ojaswin Mujoo
2025-09-10 6:07 ` Zorro Lang
2025-09-10 6:38 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 03/12] common/rc: Add a helper to run fsx on a given file Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 04/12] ltp/fsx.c: Add atomic writes support to fsx Ojaswin Mujoo
2025-09-02 15:06 ` John Garry
2025-09-05 16:29 ` Ojaswin Mujoo
2025-09-08 7:53 ` John Garry
2025-09-09 6:57 ` Ojaswin Mujoo
2025-09-09 7:55 ` John Garry
2025-09-09 8:59 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 05/12] generic: Add atomic write test using fio crc check verifier Ojaswin Mujoo
2025-09-02 15:09 ` John Garry
2025-08-22 8:02 ` [PATCH v5 06/12] generic: Add atomic write test using fio verify on file mixed mappings Ojaswin Mujoo
2025-09-02 15:10 ` John Garry
2025-08-22 8:02 ` Ojaswin Mujoo [this message]
2025-09-02 15:14 ` [PATCH v5 07/12] generic: Add atomic write multi-fsblock O_[D]SYNC tests John Garry
2025-09-05 16:30 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 08/12] generic: Stress fsx with atomic writes enabled Ojaswin Mujoo
2025-09-02 15:18 ` John Garry
2025-09-05 16:40 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 09/12] generic: Add sudden shutdown tests for multi block atomic writes Ojaswin Mujoo
2025-09-02 15:49 ` John Garry
2025-09-05 17:06 ` Ojaswin Mujoo
2025-09-08 14:27 ` John Garry
2025-09-09 6:44 ` Ojaswin Mujoo
2025-09-09 7:49 ` John Garry
2025-09-09 9:01 ` Ojaswin Mujoo
2025-09-09 9:04 ` John Garry
2025-09-09 11:43 ` Ojaswin Mujoo
2025-08-22 8:02 ` [PATCH v5 10/12] ext4: test atomic write and ioend codepaths with bigalloc Ojaswin Mujoo
2025-08-28 15:09 ` Darrick J. Wong
2025-09-02 15:52 ` John Garry
2025-08-22 8:02 ` [PATCH v5 11/12] ext4: Test atomic writes allocation and write " Ojaswin Mujoo
2025-09-02 15:54 ` John Garry
2025-09-05 17:10 ` Ojaswin Mujoo
2025-09-08 7:39 ` John Garry
2025-08-22 8:02 ` [PATCH v5 12/12] ext4: Atomic write test for extent split across leaf nodes Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55583acdfb6cb69bcea84a56cbc20754e1d2f4f4.1755849134.git.ojaswin@linux.ibm.com \
--to=ojaswin@linux.ibm.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox