[PATCH] common/rc: move rm out from if block to always delete kmemleak temp file

[PATCH] common/rc: move rm out from if block to always delete kmemleak temp file

[Misono Tomohiro]

Otherwise, *.kmemleak.tmp may remain in result folder if kmemleak is on.

Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/rc b/common/rc
index 366489bb..0c3359fd 100644
--- a/common/rc
+++ b/common/rc
@@ -3515,8 +3515,8 @@ EXPERIMENTAL kmemleak reported some memory leaks!  Due to the way kmemleak
 works, the leak might be from an earlier test, or something totally unrelated.
 ENDL
 		cat "$leak_file.tmp" >> "$leak_file"
-		rm -rf "$leak_file.tmp"
 	fi
+	rm -rf "$leak_file.tmp"
 	echo "clear" > "$kern_knob"
 }
 
-- 
2.14.3

Re: [PATCH] common/rc: move rm out from if block to always delete kmemleak temp file

[Darrick J. Wong]

On Mon, Apr 23, 2018 at 02:23:14PM +0900, Misono Tomohiro wrote:
> Otherwise, *.kmemleak.tmp may remain in result folder if kmemleak is on.
> 
> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index 366489bb..0c3359fd 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3515,8 +3515,8 @@ EXPERIMENTAL kmemleak reported some memory leaks!  Due to the way kmemleak
>  works, the leak might be from an earlier test, or something totally unrelated.
>  ENDL
>  		cat "$leak_file.tmp" >> "$leak_file"
> -		rm -rf "$leak_file.tmp"
>  	fi
> +	rm -rf "$leak_file.tmp"
>  	echo "clear" > "$kern_knob"
>  }
>  
> -- 
> 2.14.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html