[PATCH] generic/590,735: add missing _require_scratch check

[PATCH] generic/590,735: add missing _require_scratch check

[Prabhakar Pujeri]

Both tests use the scratch device without first requiring one, so they
fail messily instead of skipping when no scratch device is configured.

Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
---
 tests/generic/590 | 1 +
 tests/generic/735 | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tests/generic/590 b/tests/generic/590
index 54c26f2..0775d6f 100755
--- a/tests/generic/590
+++ b/tests/generic/590
@@ -13,6 +13,7 @@ _begin_fstest auto prealloc preallocrw
 
 . ./common/filter
 
+_require_scratch
 _require_xfs_io_command "falloc"
 
 maxextlen=$((0x1fffff))
diff --git a/tests/generic/735 b/tests/generic/735
index 60fa3dc..d7e732b 100755
--- a/tests/generic/735
+++ b/tests/generic/735
@@ -20,6 +20,7 @@ if [[ "$FSTYP" =~ ext[0-9]+ ]]; then
 fi
 
 _require_odirect
+_require_scratch
 _require_xfs_io_command "falloc"
 _require_xfs_io_command "finsert"
 _require_max_file_range_blocks $(( (1 << 32) - 1 ))
-- 
2.55.0

Re: [PATCH] generic/590,735: add missing _require_scratch check

[Darrick J. Wong]

On Mon, Aug 31, 2026 at 10:41:48AM +0000, Prabhakar Pujeri wrote:
> Both tests use the scratch device without first requiring one, so they
> fail messily instead of skipping when no scratch device is configured.
> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>

Yep, those are missing.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/generic/590 | 1 +
>  tests/generic/735 | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tests/generic/590 b/tests/generic/590
> index 54c26f2..0775d6f 100755
> --- a/tests/generic/590
> +++ b/tests/generic/590
> @@ -13,6 +13,7 @@ _begin_fstest auto prealloc preallocrw
>  
>  . ./common/filter
>  
> +_require_scratch
>  _require_xfs_io_command "falloc"
>  
>  maxextlen=$((0x1fffff))
> diff --git a/tests/generic/735 b/tests/generic/735
> index 60fa3dc..d7e732b 100755
> --- a/tests/generic/735
> +++ b/tests/generic/735
> @@ -20,6 +20,7 @@ if [[ "$FSTYP" =~ ext[0-9]+ ]]; then
>  fi
>  
>  _require_odirect
> +_require_scratch
>  _require_xfs_io_command "falloc"
>  _require_xfs_io_command "finsert"
>  _require_max_file_range_blocks $(( (1 << 32) - 1 ))
> -- 
> 2.55.0
> 
> 

Re: [PATCH] generic/590,735: add missing _require_scratch check

[Zorro Lang]

On Mon, Aug 31, 2026 at 10:41:48AM +0000, Prabhakar Pujeri wrote:
> Both tests use the scratch device without first requiring one, so they
> fail messily instead of skipping when no scratch device is configured.
> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---

Hmm... one more

And why does this patch need to be separate from the other one --
"generic/795: add missing _require_scratch check" ?

Please group patches with the same rationale and goal together, it'll prevent
them from being scattered everywhere and helps ensure I don't overlook any.
I'll drop the ones I already merged and wait for your consolidated patch or
patchset :)

Thanks,
Zorro

>  tests/generic/590 | 1 +
>  tests/generic/735 | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tests/generic/590 b/tests/generic/590
> index 54c26f2..0775d6f 100755
> --- a/tests/generic/590
> +++ b/tests/generic/590
> @@ -13,6 +13,7 @@ _begin_fstest auto prealloc preallocrw
>  
>  . ./common/filter
>  
> +_require_scratch
>  _require_xfs_io_command "falloc"
>  
>  maxextlen=$((0x1fffff))
> diff --git a/tests/generic/735 b/tests/generic/735
> index 60fa3dc..d7e732b 100755
> --- a/tests/generic/735
> +++ b/tests/generic/735
> @@ -20,6 +20,7 @@ if [[ "$FSTYP" =~ ext[0-9]+ ]]; then
>  fi
>  
>  _require_odirect
> +_require_scratch
>  _require_xfs_io_command "falloc"
>  _require_xfs_io_command "finsert"
>  _require_max_file_range_blocks $(( (1 << 32) - 1 ))
> -- 
> 2.55.0
>