[PATCH] generic/805: fix for external RT devices

[PATCH] generic/805: fix for external RT devices

[Christoph Hellwig]

use _mkfs_dev on the dm device instead of _scratch_mkfs_sized, otherwise
the file system could be created with an external RT device, and will
then fail to mount without it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/generic/805 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/generic/805 b/tests/generic/805
index ae498f5c6698..401829c4c6fc 100755
--- a/tests/generic/805
+++ b/tests/generic/805
@@ -31,7 +31,7 @@ _cleanup()
 	rm -f $tmp.*
 }
 
-_require_scratch
+_require_scratch_nocheck
 _require_dm_target linear
 _require_freeze
 
@@ -39,13 +39,13 @@ echo "Silence is golden"
 
 size=$((256 * 1024 * 1024))
 size_in_sector=$((size / 512))
-_scratch_mkfs_sized $size >> $seqres.full 2>&1
 
 node=$seq-test
 lvdev=/dev/mapper/$node
 table="0 $size_in_sector linear $SCRATCH_DEV 0"
 _dmsetup_create $node --table "$table" || \
 	_fail "failed to create dm device"
+_mkfs_dev $lvdev >> $seqres.full 2>&1
 
 _mount $lvdev $SCRATCH_MNT || _fail "failed to mount dm device"
 
-- 
2.53.0

Re: [PATCH] generic/805: fix for external RT devices

[Zorro Lang]

On Thu, Sep 24, 2026 at 08:21:18AM +0200, Christoph Hellwig wrote:
> use _mkfs_dev on the dm device instead of _scratch_mkfs_sized, otherwise
> the file system could be created with an external RT device, and will
> then fail to mount without it.

This patch makes sense to me. But I was wondering if we should have a helper
similar to _ignore_scratch_external_devices to allow a temporary device to
act as SCRATCH_DEV, so it can use the _scratch_* helpers ?

Thanks,
Zorro

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/805 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/805 b/tests/generic/805
> index ae498f5c6698..401829c4c6fc 100755
> --- a/tests/generic/805
> +++ b/tests/generic/805
> @@ -31,7 +31,7 @@ _cleanup()
>  	rm -f $tmp.*
>  }
>  
> -_require_scratch
> +_require_scratch_nocheck
>  _require_dm_target linear
>  _require_freeze
>  
> @@ -39,13 +39,13 @@ echo "Silence is golden"
>  
>  size=$((256 * 1024 * 1024))
>  size_in_sector=$((size / 512))
> -_scratch_mkfs_sized $size >> $seqres.full 2>&1
>  
>  node=$seq-test
>  lvdev=/dev/mapper/$node
>  table="0 $size_in_sector linear $SCRATCH_DEV 0"
>  _dmsetup_create $node --table "$table" || \
>  	_fail "failed to create dm device"
> +_mkfs_dev $lvdev >> $seqres.full 2>&1
>  
>  _mount $lvdev $SCRATCH_MNT || _fail "failed to mount dm device"
>  
> -- 
> 2.53.0
> 

Re: [PATCH] generic/805: fix for external RT devices

[Christoph Hellwig]

On Thu, Sep 24, 2026 at 09:56:53PM +0800, Zorro Lang wrote:
> On Thu, Sep 24, 2026 at 08:21:18AM +0200, Christoph Hellwig wrote:
> > use _mkfs_dev on the dm device instead of _scratch_mkfs_sized, otherwise
> > the file system could be created with an external RT device, and will
> > then fail to mount without it.
> 
> This patch makes sense to me. But I was wondering if we should have a helper
> similar to _ignore_scratch_external_devices to allow a temporary device to
> act as SCRATCH_DEV, so it can use the _scratch_* helpers ?

You can't just ignore external devices, as options might also not apply
any more.  We could add new helpers for just use scratch without
external devices, but IMHO there is no much benefit over just using the
_dev helpers.

Re: [PATCH] generic/805: fix for external RT devices

[Zorro Lang]

On Thu, Sep 24, 2026 at 08:21:18AM +0200, Christoph Hellwig wrote:
> use _mkfs_dev on the dm device instead of _scratch_mkfs_sized, otherwise
> the file system could be created with an external RT device, and will
> then fail to mount without it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

This change is good to me,

Reviewed-by: Zorro Lang <zlang@kernel.org>

>  tests/generic/805 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/805 b/tests/generic/805
> index ae498f5c6698..401829c4c6fc 100755
> --- a/tests/generic/805
> +++ b/tests/generic/805
> @@ -31,7 +31,7 @@ _cleanup()
>  	rm -f $tmp.*
>  }
>  
> -_require_scratch
> +_require_scratch_nocheck
>  _require_dm_target linear
>  _require_freeze
>  
> @@ -39,13 +39,13 @@ echo "Silence is golden"
>  
>  size=$((256 * 1024 * 1024))
>  size_in_sector=$((size / 512))
> -_scratch_mkfs_sized $size >> $seqres.full 2>&1
>  
>  node=$seq-test
>  lvdev=/dev/mapper/$node
>  table="0 $size_in_sector linear $SCRATCH_DEV 0"
>  _dmsetup_create $node --table "$table" || \
>  	_fail "failed to create dm device"
> +_mkfs_dev $lvdev >> $seqres.full 2>&1
>  
>  _mount $lvdev $SCRATCH_MNT || _fail "failed to mount dm device"
>  
> -- 
> 2.53.0
>