* [PATCH] git-submodule: Fix a typo
@ 2007-07-04 16:22 CJ van den Berg
2007-07-04 16:59 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: CJ van den Berg @ 2007-07-04 16:22 UTC (permalink / raw)
To: git
This typo breaks the output of git submodule status.
---
git-submodule.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 0ba0161..277fadc 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -234,7 +234,7 @@ modules_list()
continue;
fi
revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
- set_name_rev "$path" $"sha1"
+ set_name_rev "$path" "$sha1"
if git diff-files --quiet -- "$path"
then
say " $sha1 $path$revname"
--
1.5.2.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-submodule: Fix a typo
2007-07-04 16:22 [PATCH] git-submodule: Fix a typo CJ van den Berg
@ 2007-07-04 16:59 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2007-07-04 16:59 UTC (permalink / raw)
To: CJ van den Berg; +Cc: git
CJ van den Berg <cj@vdbonline.com> writes:
> This typo breaks the output of git submodule status.
>
> ---
> git-submodule.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 0ba0161..277fadc 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -234,7 +234,7 @@ modules_list()
> continue;
> fi
> revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
> - set_name_rev "$path" $"sha1"
> + set_name_rev "$path" "$sha1"
> if git diff-files --quiet -- "$path"
> then
> say " $sha1 $path$revname"
Thanks. There is another, probably from a cut-n-paste.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-04 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-04 16:22 [PATCH] git-submodule: Fix a typo CJ van den Berg
2007-07-04 16:59 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox