From: Jeff King <peff@peff.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Git Mailing List <git@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Junio C Hamano <junkio@cox.net>
Subject: Re: gitk problems: can't unset "idinlist(...)"
Date: Sat, 21 Jul 2007 02:54:05 -0400 [thread overview]
Message-ID: <20070721065405.GA9793@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.LFD.0.999.0707202335570.27249@woody.linux-foundation.org>
On Fri, Jul 20, 2007 at 11:47:24PM -0700, Linus Torvalds wrote:
> So the difference between your version and mine is that the
>
> while ((p = *pp) != NULL)
I actually like your version better (I like saving for loops for
honest-to-god, for-each-element-in-this-list iteration; munging the list
in the middle is something that you _should_ call attention to). I just
found your patch much harder to verify, because I had to make sure the
for/while change was equivalent. So you can blame Junio for writing it
wrong in the first place. :)
Junio, whatever you apply, please credit Linus; he beat me to the fix
and so my patch is completely cribbed from his. :)
-Peff
next prev parent reply other threads:[~2007-07-21 6:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 23:05 gitk problems: can't unset "idinlist(...)" Linus Torvalds
2007-07-21 5:09 ` Jeff King
2007-07-21 5:53 ` Linus Torvalds
2007-07-21 5:56 ` Junio C Hamano
2007-07-21 5:59 ` Jeff King
2007-07-21 6:06 ` Jeff King
2007-07-21 6:11 ` Linus Torvalds
2007-07-21 6:18 ` Jeff King
2007-07-21 6:24 ` Jeff King
2007-07-21 6:47 ` Linus Torvalds
2007-07-21 6:54 ` Jeff King [this message]
2007-07-21 9:32 ` pointer to pointer (was: gitk problems: can't unset "idinlist(...)") David Kastrup
2007-07-21 9:44 ` pointer to pointer David Kastrup
2007-07-21 6:34 ` gitk problems: can't unset "idinlist(...)" Linus Torvalds
2007-07-21 11:42 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070721065405.GA9793@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox