Git development
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Junio C Hamano <junkio@cox.net>
Subject: Re: gitk problems: can't unset "idinlist(...)"
Date: Fri, 20 Jul 2007 22:53:10 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0707202226130.27249@woody.linux-foundation.org> (raw)
In-Reply-To: <20070721050912.GB20622@coredump.intra.peff.net>



On Sat, 21 Jul 2007, Jeff King wrote:
> 
> Interestingly, I repeatably get the exact same error but with a
> different commit:
> 
>   7ed40918a386afc2e14a6d3da563ea6d13686c25
> 
> which looks like a totally uninteresting commit.

It seems to depend on the path limiter.

With "arch/i386", I get the 7ed409 one, with "arch/i386 arch/x86_64" I get 
a complaint about 57d1c91fa. In neither case do I see the reason.

But I think I found a clue. One thing special about that 57d1c91fa is that 
when you do

	git log --topo-order --parents --pretty=one arch/i386/ arch/x86_64/

and search for it, it first shows up as a parent for commit 9fdb62af92: 
and not just _one_ parent, but three! So it looks like the parent 
simplification is broken, and maybe gitk is unhappy for that reason.

The same is true of 7ed40918a38, btw, so yeah, I think that's it.

Junio, didn't we have some parent simplification patches recently?

			Linus

  reply	other threads:[~2007-07-21  5:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-20 23:05 gitk problems: can't unset "idinlist(...)" Linus Torvalds
2007-07-21  5:09 ` Jeff King
2007-07-21  5:53   ` Linus Torvalds [this message]
2007-07-21  5:56     ` Junio C Hamano
2007-07-21  5:59     ` Jeff King
2007-07-21  6:06       ` Jeff King
2007-07-21  6:11     ` Linus Torvalds
2007-07-21  6:18       ` Jeff King
2007-07-21  6:24         ` Jeff King
2007-07-21  6:47           ` Linus Torvalds
2007-07-21  6:54             ` Jeff King
2007-07-21  9:32             ` pointer to pointer (was: gitk problems: can't unset "idinlist(...)") David Kastrup
2007-07-21  9:44               ` pointer to pointer David Kastrup
2007-07-21  6:34         ` gitk problems: can't unset "idinlist(...)" Linus Torvalds
2007-07-21 11:42 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0707202226130.27249@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=paulus@samba.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox