Git development
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Junio C Hamano <junkio@cox.net>
Subject: Re: gitk problems: can't unset "idinlist(...)"
Date: Fri, 20 Jul 2007 23:34:02 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0707202329220.27249@woody.linux-foundation.org> (raw)
In-Reply-To: <20070721061857.GB29820@coredump.intra.peff.net>



On Sat, 21 Jul 2007, Jeff King wrote:
> 
> I just independently came to the same conclusion. Your patch looks
> correct to me (though there are some unrelated formatting changes which
> made it a little harder to read).

Yeah, I shouldn't have done that - I just ended up changing the "for()" to 
a "while()" (because we should *not* do the same thing at the end of the 
loop each time).  And as a part of that I changed the initialization to be 
at the head of the while-loop rather than in the variable declaration, 
because that's how I tend to mostly write while-loops.

But I probably should have tried to keep the patch minimal instead, so 
that it would show the changes better. Probably not a big deal.

		Linus

  parent reply	other threads:[~2007-07-21  6:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-20 23:05 gitk problems: can't unset "idinlist(...)" Linus Torvalds
2007-07-21  5:09 ` Jeff King
2007-07-21  5:53   ` Linus Torvalds
2007-07-21  5:56     ` Junio C Hamano
2007-07-21  5:59     ` Jeff King
2007-07-21  6:06       ` Jeff King
2007-07-21  6:11     ` Linus Torvalds
2007-07-21  6:18       ` Jeff King
2007-07-21  6:24         ` Jeff King
2007-07-21  6:47           ` Linus Torvalds
2007-07-21  6:54             ` Jeff King
2007-07-21  9:32             ` pointer to pointer (was: gitk problems: can't unset "idinlist(...)") David Kastrup
2007-07-21  9:44               ` pointer to pointer David Kastrup
2007-07-21  6:34         ` Linus Torvalds [this message]
2007-07-21 11:42 ` gitk problems: can't unset "idinlist(...)" Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0707202329220.27249@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=paulus@samba.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox