Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: Derrick Stolee <stolee@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2
Date: Thu, 16 Apr 2026 19:29:41 -0400	[thread overview]
Message-ID: <20260416232941.GD1904316@coredump.intra.peff.net> (raw)
In-Reply-To: <aeFF5s5m76Yz7F/Q@nand.local>

On Thu, Apr 16, 2026 at 04:26:14PM -0400, Taylor Blau wrote:

> Yeah, I agree, and sorry for the trouble here. A few thoughts:
> 
>  - In the immediate term, we should downgrade the default format to
>    write V1 MIDXs for the compatibility issues pointed out by this
>    thread. That would seem to be the minimal thing to do to make sure
>    that the 2.54 release is as smooth as possible.
> 
>  - In the medium term (i.e., on the other side of 2.54) we should
>    implement the changes that Peff sketched earlier in the thread to
>    make loading the MIDX robust towards unrecognized versions.
> 
>    Of course, that doesn't fix any old clients who don't upgrade and at
>    some point want to fetch from or otherwise interact with a repository
>    that has a V2 MIDX. But it does improve things for, say, users that
>    are on an eventual 2.55 if we make the V1->V2 by default change in
>    2.56.
> 
>  - In the long term (i.e., in 2.56 or otherwise in a release after the
>    above change is implemented) we should make V2 the default format for
>    MIDXs.

That all seems reasonable. I think the only question is how long the "in
the long term" period should be. Two versions is not very long,
especially for people who are using OS packages (think moving from one
Debian stable release to another). But that can be sorted out later.

-Peff

  reply	other threads:[~2026-04-16 23:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 15:22 [ANNOUNCE] Git v2.54.0-rc2 Junio C Hamano
2026-04-15 20:50 ` MIDX woes, was " Johannes Schindelin
2026-04-15 21:04   ` Junio C Hamano
2026-04-16  5:17     ` Jeff King
2026-04-16  5:34       ` Jeff King
2026-04-16 13:24         ` Derrick Stolee
2026-04-16 16:09           ` Junio C Hamano
2026-04-16 20:29             ` Taylor Blau
2026-04-19 22:41               ` Derrick Stolee
2026-04-20  1:52                 ` Junio C Hamano
2026-04-16 20:26           ` Taylor Blau
2026-04-16 23:29             ` Jeff King [this message]
2026-04-16 18:10         ` Junio C Hamano
2026-04-16 18:18           ` Junio C Hamano
2026-04-16 19:49             ` Jeff King
2026-04-16 20:12               ` Junio C Hamano
2026-04-16 23:23                 ` Jeff King
2026-04-17  4:15                   ` Junio C Hamano
2026-04-16 18:45           ` [PATCH] MIDX: revert the default version to v1 Junio C Hamano
2026-04-16 19:38             ` Junio C Hamano
2026-04-16 20:58               ` Junio C Hamano
2026-04-16 21:13                 ` Taylor Blau
2026-04-16 20:06             ` Jeff King
2026-04-16 20:55               ` Junio C Hamano
2026-04-16 23:24                 ` Jeff King
2026-04-16 23:26                   ` Jeff King
2026-04-16 21:12               ` Taylor Blau
2026-04-16 23:27                 ` Jeff King
2026-04-17 15:19 ` [ANNOUNCE] Git v2.54.0-rc2 Junio C Hamano
2026-04-17 17:03   ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416232941.GD1904316@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox