Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: MIDX woes, was Re: [ANNOUNCE] Git v2.54.0-rc2
Date: Wed, 15 Apr 2026 14:04:44 -0700	[thread overview]
Message-ID: <xmqq5x5s540j.fsf@gitster.g> (raw)
In-Reply-To: <8c1def10-9039-aecd-4ce4-fb4676b47e9b@gmx.de> (Johannes Schindelin's message of "Wed, 15 Apr 2026 22:50:41 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>>  * Further work on incremental repacking using MIDX/bitmap
>
> I just noticed that a fetch with v2.54.0-rc2 into an existing repository
> rendered it unusable for Git v2.53.0:
>
>   fatal: multi-pack-index version 2 not recognized
>
> Is it possible that v2.54.0-rc2 forcefully uses a MIDX version that has
> _just_ been introduced?
>
> If so, that might have been a premature bump of the default MIDX version,
> if even the preceding Git version fails to handle that MIDX version. It is
> guaranteed to cause substantial problems in setups where e.g. libgit2 or
> JGit is expected to be used interchangeably with Git. It also causes
> problems when users have to downgrade Git, or use several Git versions
> side by side (e.g. using GitHub Desktop, which bundles its own version of
> Git).

Is b2ec8e90 (midx: do not require packs to be sorted in
lexicographic order, 2026-02-24), which says

    This change produces MIDXs which may not be correctly read with external
    tools or older versions of Git. Though older versions of Git know how to
    gracefully degrade and ignore any MIDX(s) they consider corrupt,
    external tools may not be as robust. To avoid unintentionally breaking
    any such tools, guard this change behind a version bump in the MIDX's
    on-disk format.
    
relevant?  The version bump seems to be doing more harm to "older
versions of Git" that "know how to gracefully degrade" by not
allowing them to degrade.

Taylor, perhaps you would want to add some instructions on how to
recover?  Like "rm -f .git/objects/pack/*.midx" or something?

Thanks, all.

  reply	other threads:[~2026-04-15 21:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 15:22 [ANNOUNCE] Git v2.54.0-rc2 Junio C Hamano
2026-04-15 20:50 ` MIDX woes, was " Johannes Schindelin
2026-04-15 21:04   ` Junio C Hamano [this message]
2026-04-16  5:17     ` Jeff King
2026-04-16  5:34       ` Jeff King
2026-04-16 13:24         ` Derrick Stolee
2026-04-16 16:09           ` Junio C Hamano
2026-04-16 20:29             ` Taylor Blau
2026-04-19 22:41               ` Derrick Stolee
2026-04-20  1:52                 ` Junio C Hamano
2026-04-16 20:26           ` Taylor Blau
2026-04-16 23:29             ` Jeff King
2026-04-16 18:10         ` Junio C Hamano
2026-04-16 18:18           ` Junio C Hamano
2026-04-16 19:49             ` Jeff King
2026-04-16 20:12               ` Junio C Hamano
2026-04-16 23:23                 ` Jeff King
2026-04-17  4:15                   ` Junio C Hamano
2026-04-16 18:45           ` [PATCH] MIDX: revert the default version to v1 Junio C Hamano
2026-04-16 19:38             ` Junio C Hamano
2026-04-16 20:58               ` Junio C Hamano
2026-04-16 21:13                 ` Taylor Blau
2026-04-16 20:06             ` Jeff King
2026-04-16 20:55               ` Junio C Hamano
2026-04-16 23:24                 ` Jeff King
2026-04-16 23:26                   ` Jeff King
2026-04-16 21:12               ` Taylor Blau
2026-04-16 23:27                 ` Jeff King
2026-04-17 15:19 ` [ANNOUNCE] Git v2.54.0-rc2 Junio C Hamano
2026-04-17 17:03   ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5x5s540j.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox