Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jeff King <peff@peff.net>,
	 git@vger.kernel.org,
	 Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] MIDX: revert the default version to v1
Date: Thu, 16 Apr 2026 12:38:30 -0700	[thread overview]
Message-ID: <xmqqv7dqzoeh.fsf@gitster.g> (raw)
In-Reply-To: <xmqq8qam217m.fsf_-_@gitster.g> (Junio C. Hamano's message of "Thu, 16 Apr 2026 11:45:49 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> From: Jeff King <peff@peff.net>
>
> Dscho reports that fetching into a repository with Git 2.54-rc2 made
> it unusable with Git 2.53, as the recent code by default writes
> version 2 multi-pack-index files.  Version 2 is the base of more
> advanced features to come, but using it where these features are not
> used is a strict regression.
>
> As deployed versions of Git and its reimplementations may not be
> ready for the format bump, let's revert the default version of MIDX
> file we write back to V1, and adjust tests that exercise V2-specific
> features to explicitly request V2.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
>  * Let me reword the proposed log message to talk about background a
>    bit more why we want to do this.

Of course, the tip of tb/incremental-midx-part-3.3 needs to be
adjusted with this before merging to 'seen'.  I think my tree is
getting ready to push the "revert the default" down to 'master'.

----- >8 ----
SQUASH??? adjust for MIDX version default reversion

diff --git a/t/t7705-repack-incremental-midx.sh b/t/t7705-repack-incremental-midx.sh
index 562554e69b..7eb1109ec5 100755
--- a/t/t7705-repack-incremental-midx.sh
+++ b/t/t7705-repack-incremental-midx.sh
@@ -63,6 +63,9 @@ create_layers () {
 	done
 }
 
+# These incremental MIDX tests requires the V2 format.
+git config --global midx.version 2
+
 test_expect_success '--write-midx=incremental without --geometric' '
 	git init incremental-without-geometric &&
 	(

  reply	other threads:[~2026-04-16 19:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 15:22 [ANNOUNCE] Git v2.54.0-rc2 Junio C Hamano
2026-04-15 20:50 ` MIDX woes, was " Johannes Schindelin
2026-04-15 21:04   ` Junio C Hamano
2026-04-16  5:17     ` Jeff King
2026-04-16  5:34       ` Jeff King
2026-04-16 13:24         ` Derrick Stolee
2026-04-16 16:09           ` Junio C Hamano
2026-04-16 20:29             ` Taylor Blau
2026-04-19 22:41               ` Derrick Stolee
2026-04-20  1:52                 ` Junio C Hamano
2026-04-16 20:26           ` Taylor Blau
2026-04-16 23:29             ` Jeff King
2026-04-16 18:10         ` Junio C Hamano
2026-04-16 18:18           ` Junio C Hamano
2026-04-16 19:49             ` Jeff King
2026-04-16 20:12               ` Junio C Hamano
2026-04-16 23:23                 ` Jeff King
2026-04-17  4:15                   ` Junio C Hamano
2026-04-16 18:45           ` [PATCH] MIDX: revert the default version to v1 Junio C Hamano
2026-04-16 19:38             ` Junio C Hamano [this message]
2026-04-16 20:58               ` Junio C Hamano
2026-04-16 21:13                 ` Taylor Blau
2026-04-16 20:06             ` Jeff King
2026-04-16 20:55               ` Junio C Hamano
2026-04-16 23:24                 ` Jeff King
2026-04-16 23:26                   ` Jeff King
2026-04-16 21:12               ` Taylor Blau
2026-04-16 23:27                 ` Jeff King
2026-04-17 15:19 ` [ANNOUNCE] Git v2.54.0-rc2 Junio C Hamano
2026-04-17 17:03   ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv7dqzoeh.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox