From: Jeff King <peff@peff.net>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Cc: Git mailing list <git@vger.kernel.org>, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2 0/2] Make our clar tests ignore the long-tests argument
Date: Tue, 27 Oct 2026 13:44:42 -0400 [thread overview]
Message-ID: <20261027174442.GA97882@coredump.intra.peff.net> (raw)
In-Reply-To: <20261026-ks-unit-tests-ignore-long-tests-v2-0-fdbbefbd19fb@gmail.com>
On Mon, Oct 26, 2026 at 01:01:03PM +0530, Kaartic Sivaraam wrote:
> On searching for how these were handled before, I stumbled across
> 9faf3963b6 (t: introduce compatibility options to clar-based tests,
> 2024-12-13) which handled this by adding such arguments as NOOP
> arguments to t/unit-tests/unit-test.c. So, this patch does the same
> to make unit-test ignore the '-l' passed to it.
Your patch looks obviously good, but it prompted me to polish and send
in a much larger fix that I think makes this fallback option parsing
obsolete:
https://lore.kernel.org/git/20261027173205.GA97799@coredump.intra.peff.net/
I don't propose to replace your series here with mine, but just that you
might be interested in it. ;)
-Peff
next prev parent reply other threads:[~2026-10-27 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 11:01 [PATCH 0/2] Make our clar tests ignore the long-tests argument Kaartic Sivaraam
2026-10-22 11:01 ` [PATCH 1/2] unit-tests: reshuffle NOOP arguments to maintain order Kaartic Sivaraam
2026-10-23 6:50 ` Patrick Steinhardt
2026-10-22 11:01 ` [PATCH 2/2] unit-tests: ignore --long-tests Kaartic Sivaraam
2026-10-23 6:50 ` Patrick Steinhardt
2026-10-23 7:15 ` Kaartic Sivaraam
2026-10-26 7:31 ` [PATCH v2 0/2] Make our clar tests ignore the long-tests argument Kaartic Sivaraam
2026-10-26 7:31 ` [PATCH v2 1/2] unit-tests: reshuffle NOOP arguments to maintain order Kaartic Sivaraam
2026-10-26 7:31 ` [PATCH v2 2/2] unit-tests: ignore --long-tests Kaartic Sivaraam
2026-10-26 8:11 ` [PATCH v2 0/2] Make our clar tests ignore the long-tests argument Patrick Steinhardt
2026-10-26 16:10 ` Junio C Hamano
2026-10-27 17:44 ` Jeff King [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-26 7:18 Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027174442.GA97882@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox