From: "Christian Noé Ramos López" <chris@nortesoftware.dev>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] gpg-interface: fail when the ssh revocation file is missing
Date: Fri, 13 Nov 2026 18:25:09 -0500 [thread overview]
Message-ID: <20261113232552.1325109-1-chris@nortesoftware.dev> (raw)
In-Reply-To: <xmqqa4o6oq1y.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> By the way, it is not a problem this patch introduces, but the
> comment at the end of this block is a bit misleading.
Agreed. v3 replaces it with one comment at the top of the block,
which says check-novalidate runs there only to display the signature
info.
> I wonder if we should be able to somehow fold this into the earlier
> "if()" block, making it the single place that deals with failures?
Yes, that is better, and v3 does it: with the file missing, a known
key gets the error and then its signature info, as an unknown key
does, and %G? gives "U" for both.
v2 went out as a reply to this message instead of to v1; v3 will be
a reply to v1.
next prev parent reply other threads:[~2026-11-13 23:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 6:56 ssh signing: valid-before is checked at the signer's own date, and a missing revocationFile fails open Christian Noé Ramos López
2026-10-08 13:42 ` Phillip Wood
2026-10-09 12:19 ` Patrick Steinhardt
2026-10-09 13:30 ` Phillip Wood
[not found] ` <CAHGSfba9Td+Lg=Nf+nfwZY2r1_eq2Mcejn__6X=VPQkmcJttfQ@mail.gmail.com>
2026-10-09 13:29 ` Phillip Wood
2026-10-21 3:03 ` [PATCH] doc: gpg: say which date SSH key lifetimes are checked against Christian Noé Ramos López
2026-10-21 18:14 ` Junio C Hamano
2026-10-22 5:44 ` [PATCH v2] " Christian Noé Ramos López
2026-10-22 6:25 ` [PATCH] " Patrick Steinhardt
2026-10-22 16:45 ` Junio C Hamano
2026-10-30 6:12 ` Christian Noé Ramos López
2026-10-30 6:15 ` [PATCH v3] " Christian Noé Ramos López
2026-10-30 7:40 ` Patrick Steinhardt
2026-10-21 4:17 ` [PATCH] gpg-interface: fail when the ssh revocation file is missing Christian Noé Ramos López
2026-10-21 18:40 ` Junio C Hamano
2026-10-22 5:46 ` [PATCH v2] " Christian Noé Ramos López
2026-10-22 15:56 ` Junio C Hamano
2026-11-13 23:25 ` Christian Noé Ramos López [this message]
2026-11-13 23:28 ` [PATCH v3] " Christian Noé Ramos López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113232552.1325109-1-chris@nortesoftware.dev \
--to=chris@nortesoftware.dev \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox