* [GIT PULL] hotfix on fr.po for the maint branch
@ 2013-08-30 9:07 Jiang Xin
2013-08-30 16:54 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Jiang Xin @ 2013-08-30 9:07 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git List, Jean-Noel Avila, Sebastien Helleu
Hi, Junio
Please merge this commit to the maint branch.
The following changes since commit e230c568c4b9a991e3175e5f65171a566fd8e39c:
Git 1.8.4 (2013-08-23 11:49:46 -0700)
are available in the git repository at:
git://github.com/git-l10n/git-po master
for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
----------------------------------------------------------------
Sebastien Helleu (1):
l10n: fr.po: hotfix for commit 6b388fc
po/TEAMS | 1 +
po/fr.po | 1591 ++++++++++++++++++++++++++++++++++----------------------------
2 files changed, 874 insertions(+), 718 deletions(-)
--
Jiang Xin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] hotfix on fr.po for the maint branch
2013-08-30 9:07 [GIT PULL] hotfix on fr.po for the maint branch Jiang Xin
@ 2013-08-30 16:54 ` Junio C Hamano
2013-08-30 17:23 ` Jean-Noël AVILA
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2013-08-30 16:54 UTC (permalink / raw)
To: Jiang Xin; +Cc: Git List, Jean-Noel Avila, Sebastien Helleu
Jiang Xin <worldhello.net@gmail.com> writes:
> Please merge this commit to the maint branch.
>
> The following changes since commit e230c568c4b9a991e3175e5f65171a566fd8e39c:
>
> Git 1.8.4 (2013-08-23 11:49:46 -0700)
>
> are available in the git repository at:
>
> git://github.com/git-l10n/git-po master
>
> for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
>
> l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
>
> ----------------------------------------------------------------
> Sebastien Helleu (1):
> l10n: fr.po: hotfix for commit 6b388fc
Hmph, what happened that requires a "hotfix" to message strings?
>
> po/TEAMS | 1 +
> po/fr.po | 1591 ++++++++++++++++++++++++++++++++++----------------------------
> 2 files changed, 874 insertions(+), 718 deletions(-)
>
> --
> Jiang Xin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] hotfix on fr.po for the maint branch
2013-08-30 16:54 ` Junio C Hamano
@ 2013-08-30 17:23 ` Jean-Noël AVILA
2013-08-30 18:07 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Noël AVILA @ 2013-08-30 17:23 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jiang Xin, Git List, Sebastien Helleu
Le vendredi 30 août 2013 09:54:59 Junio C Hamano a écrit :
> Jiang Xin <worldhello.net@gmail.com> writes:
> > Please merge this commit to the maint branch.
> >
> > The following changes since commit
e230c568c4b9a991e3175e5f65171a566fd8e39c:
> > Git 1.8.4 (2013-08-23 11:49:46 -0700)
> >
> > are available in the git repository at:
> > git://github.com/git-l10n/git-po master
> >
> > for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
> > l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
> >
> > ----------------------------------------------------------------
> >
> > Sebastien Helleu (1):
> > l10n: fr.po: hotfix for commit 6b388fc
>
> Hmph, what happened that requires a "hotfix" to message strings?
Well, as the author of the first commit,, I must say that the quality was not
good. But it became visible and hooked up a reviewer only when it was promoted
to stable version...
There are some strings that do not make sense in the usage pages, a missing %s
in one. Agreed that applying this patch does not solve a critical issue, but
it is low risk.
>
> > po/TEAMS | 1 +
> > po/fr.po | 1591
> > ++++++++++++++++++++++++++++++++++---------------------------- 2 files
> > changed, 874 insertions(+), 718 deletions(-)
> >
> > --
> > Jiang Xin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] hotfix on fr.po for the maint branch
2013-08-30 17:23 ` Jean-Noël AVILA
@ 2013-08-30 18:07 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2013-08-30 18:07 UTC (permalink / raw)
To: Jean-Noël AVILA; +Cc: Jiang Xin, Git List, Sebastien Helleu
Jean-Noël AVILA <jn.avila@free.fr> writes:
> Le vendredi 30 août 2013 09:54:59 Junio C Hamano a écrit :
>> Jiang Xin <worldhello.net@gmail.com> writes:
>> > Please merge this commit to the maint branch.
>> >
>> > The following changes since commit
> e230c568c4b9a991e3175e5f65171a566fd8e39c:
>> > Git 1.8.4 (2013-08-23 11:49:46 -0700)
>> >
>> > are available in the git repository at:
>> > git://github.com/git-l10n/git-po master
>> >
>> > for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
>> > l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
>> >
>> > ----------------------------------------------------------------
>> >
>> > Sebastien Helleu (1):
>> > l10n: fr.po: hotfix for commit 6b388fc
>>
>> Hmph, what happened that requires a "hotfix" to message strings?
>
> Well, as the author of the first commit,, I must say that the quality was not
> good. But it became visible and hooked up a reviewer only when it was promoted
> to stable version...
>
> There are some strings that do not make sense in the usage pages, a missing %s
> in one. Agreed that applying this patch does not solve a critical issue, but
> it is low risk.
OK, I was just reacting to the "hotfix" wording and wondering the
level of urgency. Will pull to maint later before cutting 1.8.4.1.
Thanks.
>
>>
>> > po/TEAMS | 1 +
>> > po/fr.po | 1591
>> > ++++++++++++++++++++++++++++++++++---------------------------- 2 files
>> > changed, 874 insertions(+), 718 deletions(-)
>> >
>> > --
>> > Jiang Xin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-30 18:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-30 9:07 [GIT PULL] hotfix on fr.po for the maint branch Jiang Xin
2013-08-30 16:54 ` Junio C Hamano
2013-08-30 17:23 ` Jean-Noël AVILA
2013-08-30 18:07 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox