Git development
 help / color / mirror / Atom feed
From: Ben Knoble <ben.knoble@gmail.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: "Phillip Wood" <phillip.wood123@gmail.com>,
	"Jelle van der Waa" <jelle@vdwaa.nl>,
	git@vger.kernel.org, "Patrick Steinhardt" <ps@pks.im>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Phillip Wood" <phillip.wood@dunelm.org.uk>,
	"Harald Nordgren" <haraldnordgren@gmail.com>,
	"René Scharfe" <l.s.r@web.de>
Subject: Re: [RFC PATCH 0/2] Support --verbose in git history
Date: Tue, 10 Nov 2026 12:15:20 -0500	[thread overview]
Message-ID: <53CA2747-58F6-4A7C-81EC-33EABF0000FC@gmail.com> (raw)
In-Reply-To: <CAOLa=ZQowi+fepj+RNegTZhK_Jy4G8VLE_Af2UdsO8-rCdviJQ@mail.gmail.com>



> Le 10 nov. 2026 à 08:13, Karthik Nayak <karthik.188@gmail.com> a écrit :
> 
> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
>>> On 09/11/2026 12:43, D. Ben Knoble wrote:
>>> On Mon, Nov 9, 2026 at 7:06 AM Karthik Nayak <karthik.188@gmail.com> wrote:
>>>> 
>>>> My preference would be to make this (current patch) default behavior and
>>>> not even have an option. I don't see a disadvantage of having the diff
>>>> always being shown and it definitely is a better default to have.
>>> 
>>> When the diff is extremely long, or if the user has other means of
>>> obtaining it and wants the editor to open quickly, it may not be
>>> desired. So I'd prefer to still have it optional, personally.
>> 
>> Another case where we might not want the diff is scripted editing as it
>> is much easier if the script does not have to worry about the diff
>> getting in the way of its edits. Personally I'd be happy to see this on
>> by default - the history command is marked as experimental so if having
>> it on by default rather than following "commit.verbose" proves to be
>> problematic we can always change it in the future. If we were staring
>> again I'd also make "commit.verbose" on by default as well so maybe I'm
>> biased.
>> 
>> Thanks
>> 
>> Phillip
> 
> I'm on board with this suggestion. Plus, I see 'git history' to be more
> user facing and it's always nicer to have better defaults for users.
> Showing diffs and verbose information seems to be inline with that. We
> could add an option to disable such output for scripts (but that can be
> done later as you suggested).
> <signature.asc>

I can live with opt-out as long as I can turn it off via config.

  reply	other threads:[~2026-11-10 17:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 19:30 [RFC PATCH 0/2] Support --verbose in git history Jelle van der Waa
2026-11-07 19:30 ` [RFC PATCH 1/2] history: drop redundant strbuf_stripspace() Jelle van der Waa
2026-11-07 19:30 ` [RFC PATCH 2/2] history: add --verbose option for reword Jelle van der Waa
2026-11-09 10:17   ` Phillip Wood
2026-11-07 19:49 ` [RFC PATCH 0/2] Support --verbose in git history D. Ben Knoble
2026-11-09 10:18   ` Phillip Wood
2026-11-09 12:06     ` Karthik Nayak
2026-11-09 12:43       ` D. Ben Knoble
2026-11-09 14:14         ` Phillip Wood
2026-11-10 13:13           ` Karthik Nayak
2026-11-10 17:15             ` Ben Knoble [this message]
2026-11-11 10:46               ` Patrick Steinhardt
2026-11-11 13:57                 ` Phillip Wood
2026-11-11 14:03                   ` Patrick Steinhardt
2026-11-11 15:39                     ` Ben Knoble
2026-11-11 16:07                       ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CA2747-58F6-4A7C-81EC-33EABF0000FC@gmail.com \
    --to=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=haraldnordgren@gmail.com \
    --cc=jelle@vdwaa.nl \
    --cc=karthik.188@gmail.com \
    --cc=l.s.r@web.de \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox