Git development
 help / color / mirror / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>,
	Jelle van der Waa <jelle@vdwaa.nl>
Cc: git@vger.kernel.org, "Patrick Steinhardt" <ps@pks.im>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Phillip Wood" <phillip.wood@dunelm.org.uk>,
	"Harald Nordgren" <haraldnordgren@gmail.com>,
	"René Scharfe" <l.s.r@web.de>
Subject: Re: [RFC PATCH 0/2] Support --verbose in git history
Date: Mon, 9 Nov 2026 10:18:07 +0000	[thread overview]
Message-ID: <bf54db39-d10e-428f-8c6d-b444f37cce81@gmail.com> (raw)
In-Reply-To: <CALnO6CBarutmydfmHDM=y5yfUCQY5SxKKcoCrd0NXCuNVkDuJQ@mail.gmail.com>

On 07/11/2026 19:49, D. Ben Knoble wrote:
> On Sat, Nov 7, 2026 at 2:36 PM Jelle van der Waa <jelle@vdwaa.nl> wrote:
>>
> 
> Anyway, my point is, there's a lot of possible meanings for "verbose",

That's a good point

> so maybe we could use "--commit-verbose" (blech), "--diff-in-editor",
> or some other thing that smarter folks than I will come up with which
> clearly signals what we're about?

Off the top of my head --show-diff, though I'm not sure that's any 
better than your suggestions

>> Other git history subcommands like split, squash and fixup could also
>> support --verbose under some circumstances (without --no-edit for fixup
>> or only with --reedit-message for fixup)

That, and supporting "commit.verbose" is a good idea

Thanks

Phillip

>> I would be happy to work start with landing support for --verbose for
>> git history reword, ideally with it also supporting the "commit.verbose"
>> configuration option. Further patches could then add support for other
>> subcommands where it makes sense.
>>
>> Jelle van der Waa (2):
>>    history: drop redundant strbuf_stripspace()
>>    history: add --verbose option for reword
>>
>>   Documentation/git-history.adoc | 11 +++-
>>   builtin/history.c              | 61 ++++++++++++++++++---
>>   t/t3451-history-reword.sh      | 97 ++++++++++++++++++++++++++++++++++
>>   3 files changed, 160 insertions(+), 9 deletions(-)
>>
>> --
>> 2.56.0
> 
> Thanks for an interesting idea.
> 


  reply	other threads:[~2026-11-09 10:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 19:30 [RFC PATCH 0/2] Support --verbose in git history Jelle van der Waa
2026-11-07 19:30 ` [RFC PATCH 1/2] history: drop redundant strbuf_stripspace() Jelle van der Waa
2026-11-07 19:30 ` [RFC PATCH 2/2] history: add --verbose option for reword Jelle van der Waa
2026-11-09 10:17   ` Phillip Wood
2026-11-07 19:49 ` [RFC PATCH 0/2] Support --verbose in git history D. Ben Knoble
2026-11-09 10:18   ` Phillip Wood [this message]
2026-11-09 12:06     ` Karthik Nayak
2026-11-09 12:43       ` D. Ben Knoble
2026-11-09 14:14         ` Phillip Wood
2026-11-10 13:13           ` Karthik Nayak
2026-11-10 17:15             ` Ben Knoble
2026-11-11 10:46               ` Patrick Steinhardt
2026-11-11 13:57                 ` Phillip Wood
2026-11-11 14:03                   ` Patrick Steinhardt
2026-11-11 15:39                     ` Ben Knoble
2026-11-11 16:07                       ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf54db39-d10e-428f-8c6d-b444f37cce81@gmail.com \
    --to=phillip.wood123@gmail.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=haraldnordgren@gmail.com \
    --cc=jelle@vdwaa.nl \
    --cc=l.s.r@web.de \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox