From: Patrick Steinhardt <ps@pks.im>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: "Phillip Wood" <phillip.wood123@gmail.com>,
"Karthik Nayak" <karthik.188@gmail.com>,
"Jelle van der Waa" <jelle@vdwaa.nl>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>,
"Harald Nordgren" <haraldnordgren@gmail.com>,
"René Scharfe" <l.s.r@web.de>
Subject: Re: [RFC PATCH 0/2] Support --verbose in git history
Date: Wed, 11 Nov 2026 17:07:35 +0100 [thread overview]
Message-ID: <avSSx_RvAlMrj4Cz@pks.im> (raw)
In-Reply-To: <6F40E344-D1D1-487E-B5C4-1ADC0B06F749@gmail.com>
On Wed, Nov 11, 2026 at 10:39:51AM -0500, Ben Knoble wrote:
>
> > Le 11 nov. 2026 à 09:03, Patrick Steinhardt <ps@pks.im> a écrit :
> >
> > On Wed, Nov 11, 2026 at 01:57:46PM +0000, Phillip Wood wrote:
> >> Hi Patrick
> >>
> >>> On 11/11/2026 10:46, Patrick Steinhardt wrote:
> >>> On Tue, Nov 10, 2026 at 12:15:20PM -0500, Ben Knoble wrote:
> >>>>> Le 10 nov. 2026 à 08:13, Karthik Nayak <karthik.188@gmail.com> a écrit :
> >>>>> Phillip Wood <phillip.wood123@gmail.com> writes:
> >>>>>>
> >>>>>> Another case where we might not want the diff is scripted editing as it
> >>>>>> is much easier if the script does not have to worry about the diff
> >>>>>> getting in the way of its edits. Personally I'd be happy to see this on
> >>>>>> by default - the history command is marked as experimental so if having
> >>>>>> it on by default rather than following "commit.verbose" proves to be
> >>>>>> problematic we can always change it in the future. If we were staring
> >>>>>> again I'd also make "commit.verbose" on by default as well so maybe I'm
> >>>>>> biased.
> >>>>>>
> >>>>> I'm on board with this suggestion. Plus, I see 'git history' to be more
> >>>>> user facing and it's always nicer to have better defaults for users.
> >>>>> Showing diffs and verbose information seems to be inline with that. We
> >>>>> could add an option to disable such output for scripts (but that can be
> >>>>> done later as you suggested).
> >>>>> <signature.asc>
> >>>>
> >>>> I can live with opt-out as long as I can turn it off via config.
> >>>
> >>> Yeah, agreed. For me there's two important parts, where being able to
> >>> disable this is the first one. The second part is that we need to make
> >>> sure that such a format can work for every subcommand of git-history(1)
> >>> so that we don't have to have multiple different formats for it.
> >>
> >> Can I just check what you mean by "format" please. It is not clear if that
> >> refers to the option name, or the way the diff is presented in the message
> >> template (or both?).
> >
> > Both probably, but what I meant is the output format. So it would need
> > to be able to cover:
> >
> > - Changes to the commit layout (e.g. `git history split`).
> >
> > - Changes to the commit order (a future `git history move`).
> >
> > - Changes to the commit message.
> >
> > - Updates to multiple references.
> >
> > I don't think we need to have everything implemented in a first
> > iteration. But the output format should be flexible enough to display
> > these kinds of changes.
> >
> > To me it almost feels like what we want is essentially the format used
> > by git-range-diff(1).
> >
> > Patrick
>
> Interesting; I certainly would appreciate range-diff-like content *somewhere*
> when using git-history. The original proposal was more like commit’s
> verbose diff in the editor, though, and I can see a desire to have that
> in all of the supported subcommands, too (maybe just as a reminder).
Oh, right. Shouldn't be posting on the mailing with a headache, I guess.
Patrick
prev parent reply other threads:[~2026-11-11 16:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 19:30 [RFC PATCH 0/2] Support --verbose in git history Jelle van der Waa
2026-11-07 19:30 ` [RFC PATCH 1/2] history: drop redundant strbuf_stripspace() Jelle van der Waa
2026-11-07 19:30 ` [RFC PATCH 2/2] history: add --verbose option for reword Jelle van der Waa
2026-11-09 10:17 ` Phillip Wood
2026-11-07 19:49 ` [RFC PATCH 0/2] Support --verbose in git history D. Ben Knoble
2026-11-09 10:18 ` Phillip Wood
2026-11-09 12:06 ` Karthik Nayak
2026-11-09 12:43 ` D. Ben Knoble
2026-11-09 14:14 ` Phillip Wood
2026-11-10 13:13 ` Karthik Nayak
2026-11-10 17:15 ` Ben Knoble
2026-11-11 10:46 ` Patrick Steinhardt
2026-11-11 13:57 ` Phillip Wood
2026-11-11 14:03 ` Patrick Steinhardt
2026-11-11 15:39 ` Ben Knoble
2026-11-11 16:07 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avSSx_RvAlMrj4Cz@pks.im \
--to=ps@pks.im \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=haraldnordgren@gmail.com \
--cc=jelle@vdwaa.nl \
--cc=karthik.188@gmail.com \
--cc=l.s.r@web.de \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox