From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Patrick Steinhardt" <ps@pks.im>
Cc: git@vger.kernel.org,
"Kristoffer Haugsbakk" <code@khaugsbakk.name>,
"Karthik Nayak" <karthik.188@gmail.com>
Subject: Re: [PATCH 1/2] doc: refs: put ref migration warning under the command
Date: Tue, 04 Aug 2026 21:09:25 +0200 [thread overview]
Message-ID: <7f34d9b6-de00-44c5-a59c-11f154e7a64a@app.fastmail.com> (raw)
In-Reply-To: <anH3k9PvWHMpWLT_@pks.im>
On Tue, Aug 4, 2026, at 16:30, Patrick Steinhardt wrote:
>>[snip]
>> diff --git a/Documentation/git-refs.adoc b/Documentation/git-refs.adoc
>> index ce278c59bfc..98828041c23 100644
>> --- a/Documentation/git-refs.adoc
>> +++ b/Documentation/git-refs.adoc
>> @@ -35,6 +35,21 @@ COMMANDS
>>
>> `migrate`::
>> Migrate ref store between different formats.
>> ++
>> +[CAUTION]
>> +--
>
> Hm, okay, first time I see this format. It feels like the rendered
> version is indented once level too deep, but I guess that's more of a
> problem with how asciidoc decides to process this. And it's a tiny nit
> only that may not even be worth addressing.
The admonition format is used in many places in the docs, but probably
mostly in the one-block/paragraph format:
NOTE: <paragraph>
Not this this open-block syntax. (But see git-blame(1) for an open block
`NOTE` example.)
Like two times in git-clone(1). On that doc there is a contrast between
this markup and a `NOTE:` which is just that plain text. With just
`NOTE:`:
This option ...
NOTE: This operation ...
And with the markup (manpage):
When the repository ...
NOTE
this is a possibly dangerous operation; ...
Or in HTML:
When the repository ...
NOTE | this is a possibly dangerous operation; ...
| ...
| ...
This is just an informational note and not an argument for using this
particular construct.
By the way, I think I looked at the AsciiDoc admonition reference[1] and
saw `CAUTION` and `WARNING`, but now I don’t recall why I chose Caution
over Warning.
🔗 1: https://docs.asciidoctor.org/asciidoc/latest/blocks/admonitions/
Thanks for taking a look.
next prev parent reply other threads:[~2026-08-04 19:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 9:07 [PATCH 0/2] doc: refs: put ref migration warning under the command kristofferhaugsbakk
2026-07-31 9:07 ` [PATCH 1/2] " kristofferhaugsbakk
2026-08-04 14:30 ` Patrick Steinhardt
2026-08-04 19:09 ` Kristoffer Haugsbakk [this message]
2026-08-05 8:07 ` Patrick Steinhardt
2026-08-05 9:13 ` Kristoffer Haugsbakk
2026-07-31 9:07 ` [PATCH 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-04 14:30 ` Patrick Steinhardt
2026-07-31 16:39 ` [PATCH 0/2] doc: refs: put ref migration warning under the command Junio C Hamano
2026-08-04 14:30 ` Patrick Steinhardt
2026-08-05 19:02 ` [PATCH v2 " kristofferhaugsbakk
2026-08-05 19:02 ` [PATCH v2 1/2] " kristofferhaugsbakk
2026-08-05 19:02 ` [PATCH v2 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-06 5:15 ` [PATCH v2 0/2] doc: refs: put ref migration warning under the command Patrick Steinhardt
2026-08-06 17:32 ` Junio C Hamano
2026-08-06 6:20 ` [PATCH v3 " kristofferhaugsbakk
2026-08-06 6:20 ` [PATCH v3 1/2] " kristofferhaugsbakk
2026-08-06 6:20 ` [PATCH v3 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-06 11:01 ` [PATCH v3 0/2] doc: refs: put ref migration warning under the command Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f34d9b6-de00-44c5-a59c-11f154e7a64a@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox