From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: kristofferhaugsbakk@fastmail.com, git@vger.kernel.org,
Kristoffer Haugsbakk <code@khaugsbakk.name>,
Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH 0/2] doc: refs: put ref migration warning under the command
Date: Tue, 4 Aug 2026 16:30:56 +0200 [thread overview]
Message-ID: <anH3oN3JRaG1eEfK@pks.im> (raw)
In-Reply-To: <xmqqbjbncdv5.fsf@gitster.g>
On Fri, Jul 31, 2026 at 09:39:42AM -0700, Junio C Hamano wrote:
> kristofferhaugsbakk@fastmail.com writes:
>
> > From: Kristoffer Haugsbakk <code@khaugsbakk.name>
> >
> > Topic name: doc-refs-migrate-limitations
> >
> > Topic summary: Put ref migration warning as an admonition under the command
> > so that it is visible.
>
> The caveat only applies to the "migrate" subcommand, and the new
> placement gives us a much better logical organization.
>
> > That’s the first patch. The second patch adds a missing `linkgit` since it
> > touches that same warning text.
>
> Looks good. Thanks.
Both patches look good to me. The indentation feels one level too deep
on the firstr patch, but this is a tiny nitpick that we may not even
want to address in the first place.
Thanks!
Patrick
next prev parent reply other threads:[~2026-08-04 14:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 9:07 [PATCH 0/2] doc: refs: put ref migration warning under the command kristofferhaugsbakk
2026-07-31 9:07 ` [PATCH 1/2] " kristofferhaugsbakk
2026-08-04 14:30 ` Patrick Steinhardt
2026-08-04 19:09 ` Kristoffer Haugsbakk
2026-08-05 8:07 ` Patrick Steinhardt
2026-08-05 9:13 ` Kristoffer Haugsbakk
2026-07-31 9:07 ` [PATCH 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-04 14:30 ` Patrick Steinhardt
2026-07-31 16:39 ` [PATCH 0/2] doc: refs: put ref migration warning under the command Junio C Hamano
2026-08-04 14:30 ` Patrick Steinhardt [this message]
2026-08-05 19:02 ` [PATCH v2 " kristofferhaugsbakk
2026-08-05 19:02 ` [PATCH v2 1/2] " kristofferhaugsbakk
2026-08-05 19:02 ` [PATCH v2 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-06 5:15 ` [PATCH v2 0/2] doc: refs: put ref migration warning under the command Patrick Steinhardt
2026-08-06 17:32 ` Junio C Hamano
2026-08-06 6:20 ` [PATCH v3 " kristofferhaugsbakk
2026-08-06 6:20 ` [PATCH v3 1/2] " kristofferhaugsbakk
2026-08-06 6:20 ` [PATCH v3 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-06 11:01 ` [PATCH v3 0/2] doc: refs: put ref migration warning under the command Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anH3oN3JRaG1eEfK@pks.im \
--to=ps@pks.im \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox