From: Patrick Steinhardt <ps@pks.im>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>,
Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH 1/2] doc: refs: put ref migration warning under the command
Date: Tue, 4 Aug 2026 16:30:43 +0200 [thread overview]
Message-ID: <anH3k9PvWHMpWLT_@pks.im> (raw)
In-Reply-To: <ref_migration_warning.b0a@msgid.xyz>
On Fri, Jul 31, 2026 at 11:07:02AM +0200, kristofferhaugsbakk@fastmail.com wrote:
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>
> I have to scroll down at least three screens in man(1) from the
> `migrate` description in order to see the “known limitations” for
> it. This is important information since the text says that concurrent
> writes can lead to an inconsistent migrated state. Let’s move that text
> up to the command description and put it inside a Caution admonition.
>
> This section made sense when it was added in 25a0023f (builtin/refs:
> new command to migrate ref storage formats, 2024-06-06); `migrate` was
> the only subcommand, and this section was visible from the command
> description. A one-page man page. But that is not the case anymore
> now that the command has nine subcommands to describe.
That feels quite sensible indeed.
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
> Documentation/git-refs.adoc | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/git-refs.adoc b/Documentation/git-refs.adoc
> index ce278c59bfc..98828041c23 100644
> --- a/Documentation/git-refs.adoc
> +++ b/Documentation/git-refs.adoc
> @@ -35,6 +35,21 @@ COMMANDS
>
> `migrate`::
> Migrate ref store between different formats.
> ++
> +[CAUTION]
> +--
Hm, okay, first time I see this format. It feels like the rendered
version is indented once level too deep, but I guess that's more of a
problem with how asciidoc decides to process this. And it's a tiny nit
only that may not even be worth addressing.
Patrick
next prev parent reply other threads:[~2026-08-04 14:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 9:07 [PATCH 0/2] doc: refs: put ref migration warning under the command kristofferhaugsbakk
2026-07-31 9:07 ` [PATCH 1/2] " kristofferhaugsbakk
2026-08-04 14:30 ` Patrick Steinhardt [this message]
2026-08-04 19:09 ` Kristoffer Haugsbakk
2026-08-05 8:07 ` Patrick Steinhardt
2026-08-05 9:13 ` Kristoffer Haugsbakk
2026-07-31 9:07 ` [PATCH 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-04 14:30 ` Patrick Steinhardt
2026-07-31 16:39 ` [PATCH 0/2] doc: refs: put ref migration warning under the command Junio C Hamano
2026-08-04 14:30 ` Patrick Steinhardt
2026-08-05 19:02 ` [PATCH v2 " kristofferhaugsbakk
2026-08-05 19:02 ` [PATCH v2 1/2] " kristofferhaugsbakk
2026-08-05 19:02 ` [PATCH v2 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-06 5:15 ` [PATCH v2 0/2] doc: refs: put ref migration warning under the command Patrick Steinhardt
2026-08-06 17:32 ` Junio C Hamano
2026-08-06 6:20 ` [PATCH v3 " kristofferhaugsbakk
2026-08-06 6:20 ` [PATCH v3 1/2] " kristofferhaugsbakk
2026-08-06 6:20 ` [PATCH v3 2/2] doc: refs: linkgit to git-maintenance(1) kristofferhaugsbakk
2026-08-06 11:01 ` [PATCH v3 0/2] doc: refs: put ref migration warning under the command Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anH3k9PvWHMpWLT_@pks.im \
--to=ps@pks.im \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox