* file names
@ 2010-12-09 17:05 Thiago Farina
2010-12-09 17:51 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Thiago Farina @ 2010-12-09 17:05 UTC (permalink / raw)
To: Git Mailing List
Hi, I was was looking into the file names and noticed that they are
not consistent.
Some files are named like:
foo-bar.[c/h]
Others are:
foo_bar.[c/h]
On top of the git directory:
# With dash
$ lc *.c | grep - | wc -l
72
$ lc *.h | grep - | wc -l
25
# With underline
$ ls *.c | grep _ | wc -l
5
$ ls *.h | grep _ | wc -l
1
So it seems from this data, there is a preference for naming files
using dash over underline.
So the question is, should the files using underline be converted to
use dash instead? And should this be documented somewhere? Maybe in
CodingGuidelines?
Thanks in advance.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: file names
2010-12-09 17:05 file names Thiago Farina
@ 2010-12-09 17:51 ` Junio C Hamano
2010-12-09 18:00 ` Thiago Farina
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2010-12-09 17:51 UTC (permalink / raw)
To: Thiago Farina; +Cc: Git Mailing List
Thiago Farina <tfransosi@gmail.com> writes:
> So it seems from this data, there is a preference for naming files
> using dash over underline.
Yes.
> So the question is, should the files using underline be converted to
> use dash instead?
If this were before v1.0.0, it might have made some sense, but not at this
moment. So the answer to "should?" (or "could?") is a firm "no", which is
always different from the answer to "wouldn't it have been nicer if they
were named differently?"
Or just after a large version bump (say 1.8.0), perhaps.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: file names
2010-12-09 17:51 ` Junio C Hamano
@ 2010-12-09 18:00 ` Thiago Farina
0 siblings, 0 replies; 3+ messages in thread
From: Thiago Farina @ 2010-12-09 18:00 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List
On Thu, Dec 9, 2010 at 3:51 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Thiago Farina <tfransosi@gmail.com> writes:
>
>> So it seems from this data, there is a preference for naming files
>> using dash over underline.
>
> Yes.
>
>> So the question is, should the files using underline be converted to
>> use dash instead?
>
> If this were before v1.0.0, it might have made some sense, but not at this
> moment. So the answer to "should?" (or "could?") is a firm "no", which is
> always different from the answer to "wouldn't it have been nicer if they
> were named differently?"
>
Right.
What about documenting it? Is it worth, but only on version 1.8.0?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-09 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-09 17:05 file names Thiago Farina
2010-12-09 17:51 ` Junio C Hamano
2010-12-09 18:00 ` Thiago Farina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox