* annotate.perl triggers rpm bug [not found] <20060310162320.0a98352b.seanlkml@sympatico.ca> @ 2006-03-10 21:23 ` sean 2006-03-11 7:11 ` Junio C Hamano 0 siblings, 1 reply; 3+ messages in thread From: sean @ 2006-03-10 21:23 UTC (permalink / raw) To: Ryan Anderson; +Cc: git Hi Ryan Commit 87475f4 exposes a problem in the creation of rpms (at least on Fedora boxes). RPM automatically creates a dependency for any perl "use" lines, and the above commit fools it into creating a false dependecy for the nonexistent perl package "revs" because of this portion of the diff: + -S, --rev-file revs-file + use revs from revs-file instead of calling git-rev-list ^^ fools rpm Obviously this creates a problem when someone goes to install the git-core rpm. Any chance we could get a small change to work around this bug in rpm? Thanks, Sean diff --git a/git-annotate.perl b/git-annotate.perl index feea0a2..6805b8b 100755 --- a/git-annotate.perl +++ b/git-annotate.perl @@ -20,7 +20,7 @@ sub usage() { -r, --rename Follow renames (Defaults on). -S, --rev-file revs-file - use revs from revs-file instead of calling git-rev-list + uses revs from revs-file instead of calling git-rev-list -h, --help This message. '; ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: annotate.perl triggers rpm bug 2006-03-10 21:23 ` annotate.perl triggers rpm bug sean @ 2006-03-11 7:11 ` Junio C Hamano [not found] ` <20060311023928.538097fd.seanlkml@sympatico.ca> 0 siblings, 1 reply; 3+ messages in thread From: Junio C Hamano @ 2006-03-11 7:11 UTC (permalink / raw) To: sean; +Cc: git sean <seanlkml@sympatico.ca> writes: > .... RPM automatically creates a dependency for any > perl "use" lines, and the above commit fools it into creating a false > dependecy... Sheesh -- broken packaging. > diff --git a/git-annotate.perl b/git-annotate.perl > index feea0a2..6805b8b 100755 > --- a/git-annotate.perl > +++ b/git-annotate.perl > @@ -20,7 +20,7 @@ sub usage() { > -r, --rename > Follow renames (Defaults on). > -S, --rev-file revs-file > - use revs from revs-file instead of calling git-rev-list > + uses revs from revs-file instead of calling git-rev-list > -h, --help > This message. > '; How about upcasing the word like other lines? ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20060311023928.538097fd.seanlkml@sympatico.ca>]
* Re: annotate.perl triggers rpm bug [not found] ` <20060311023928.538097fd.seanlkml@sympatico.ca> @ 2006-03-11 7:39 ` sean 0 siblings, 0 replies; 3+ messages in thread From: sean @ 2006-03-11 7:39 UTC (permalink / raw) To: Junio C Hamano; +Cc: git On Fri, 10 Mar 2006 23:11:01 -0800 Junio C Hamano <junkio@cox.net> wrote: > Sheesh -- broken packaging. Yeah, not rpm's proudest moment. > How about upcasing the word like other lines? That seems to fix the dependency problem too and makes a little more sense. Sean diff --git a/git-annotate.perl b/git-annotate.perl index feea0a2..9df72a1 100755 --- a/git-annotate.perl +++ b/git-annotate.perl @@ -20,7 +20,7 @@ sub usage() { -r, --rename Follow renames (Defaults on). -S, --rev-file revs-file - use revs from revs-file instead of calling git-rev-list + Use revs from revs-file instead of calling git-rev-list -h, --help This message. '; ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-03-11 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060310162320.0a98352b.seanlkml@sympatico.ca>
2006-03-10 21:23 ` annotate.perl triggers rpm bug sean
2006-03-11 7:11 ` Junio C Hamano
[not found] ` <20060311023928.538097fd.seanlkml@sympatico.ca>
2006-03-11 7:39 ` sean
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox