* [PATCH] Clean generated files a bit more.
@ 2005-08-12 9:41 Junio C Hamano
2005-08-12 11:40 ` Petr Baudis
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2005-08-12 9:41 UTC (permalink / raw)
To: git
Also attempt to build a source package for debian.
---
Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
b263f24ce4f12dd39cfcd922c56a32292c6232c9
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -238,14 +238,14 @@ rpm: dist
deb: dist
rm -rf $(GIT_TARNAME)
tar zxf $(GIT_TARNAME).tar.gz
+ dpkg-source -b $(GIT_TARNAME)
cd $(GIT_TARNAME) && fakeroot debian/rules binary
### Cleaning rules
clean:
rm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)
- rm -f $(GIT_TARNAME).tar.gz git-core.spec
- rm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb
+ rm -f git-core.spec *.deb *.dsc *.tar.gz
rm -rf $(GIT_TARNAME)
$(MAKE) -C tools/ clean
$(MAKE) -C Documentation/ clean
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Clean generated files a bit more.
2005-08-12 9:41 [PATCH] Clean generated files a bit more Junio C Hamano
@ 2005-08-12 11:40 ` Petr Baudis
2005-08-12 13:55 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Petr Baudis @ 2005-08-12 11:40 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Dear diary, on Fri, Aug 12, 2005 at 11:41:34AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> Also attempt to build a source package for debian.
> ---
>
> Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> b263f24ce4f12dd39cfcd922c56a32292c6232c9
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -238,14 +238,14 @@ rpm: dist
> deb: dist
> rm -rf $(GIT_TARNAME)
> tar zxf $(GIT_TARNAME).tar.gz
> + dpkg-source -b $(GIT_TARNAME)
> cd $(GIT_TARNAME) && fakeroot debian/rules binary
>
> ### Cleaning rules
>
> clean:
> rm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)
> - rm -f $(GIT_TARNAME).tar.gz git-core.spec
> - rm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb
> + rm -f git-core.spec *.deb *.dsc *.tar.gz
This makes me a bit nervous - why are you making the rules more general?
make clean removing random tarballs of mine happenning to dwell in that
directory is fearsome.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone. -- Alan Cox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Clean generated files a bit more.
2005-08-12 11:40 ` Petr Baudis
@ 2005-08-12 13:55 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2005-08-12 13:55 UTC (permalink / raw)
To: Petr Baudis; +Cc: git
Petr Baudis <pasky@suse.cz> writes:
> This makes me a bit nervous - why are you making the rules more general?
> make clean removing random tarballs of mine happenning to dwell in that
> directory is fearsome.
That is a valid concern. I'd drop that *.tar.gz part at
least and probably the *.deb *.dsc part as well. Thanks for
sanity checking.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-08-12 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-12 9:41 [PATCH] Clean generated files a bit more Junio C Hamano
2005-08-12 11:40 ` Petr Baudis
2005-08-12 13:55 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox