Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Kastrup <dak@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add a test for git-commit being confused by relative GIT_DIR
Date: Sat, 11 Aug 2007 18:55:46 -0700	[thread overview]
Message-ID: <7vvebljz31.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <85tzr5spaj.fsf@lola.goethe.zz> (David Kastrup's message of "Sun, 12 Aug 2007 00:02:28 +0200")

David Kastrup <dak@gnu.org> writes:

> +test_expect_success 'Setting up post-commit hook' '
> +mkdir -p .git/hooks &&
> +cat <<EOF >.git/hooks/post-commit &&
> +#!/bin/sh
> +touch $(pwd)/output
> +echo "Post commit hook was called."
> +EOF
> +chmod +x .git/hooks/post-commit'

We have avoided to use here text inside test_expect_success, as
there have been reports that some otherwise reasonably usable
shells do not grok it.  Although I prefer to do everything,
including the set-up part, inside test_expect_success, please
move this code outside.

Also I do not think you would want to say touch $(pwd)/output
there inside the here text that begins with <<EOF not <<\EOF.

  reply	other threads:[~2007-08-12  1:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10 14:02 [PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR David Kastrup
2007-08-10 16:21 ` [fixed PATCH] " David Kastrup
2007-08-11 10:06   ` Junio C Hamano
2007-08-11 10:32     ` David Kastrup
2007-08-11 12:12       ` David Kastrup
2007-08-11 12:29         ` David Kastrup
2007-08-11 19:53           ` Junio C Hamano
2007-08-11 21:04             ` David Kastrup
2007-08-11 22:02             ` [PATCH] Add a test for git-commit being confused by relative GIT_DIR David Kastrup
2007-08-12  1:55               ` Junio C Hamano [this message]
2007-08-12  6:47                 ` David Kastrup
2007-08-12 17:05                   ` Junio C Hamano
2007-08-12 18:44                     ` David Kastrup
2007-08-11 12:51         ` [fixed PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR Steven Grimm
2007-08-11 20:10           ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2007-08-13  5:38 [PATCH] Add a test for git-commit being confused by relative GIT_DIR David Kastrup
2007-08-13 23:51 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvebljz31.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=dak@gnu.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox