From: Junio C Hamano <gitster@pobox.com>
To: Steven Grimm <koreth@midwinter.com>
Cc: David Kastrup <dak@gnu.org>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [fixed PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR
Date: Sat, 11 Aug 2007 13:10:31 -0700 [thread overview]
Message-ID: <7vveblltmw.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <46BDB0E7.3020506@midwinter.com> (Steven Grimm's message of "Sat, 11 Aug 2007 20:51:51 +0800")
Steven Grimm <koreth@midwinter.com> writes:
> David Kastrup wrote:
>> Actually, wouldn't by far the most straightforward thing be if
>> git-rev-parse --git-dir always returned an absolute path (even when
>> being passed a relative path in GIT_DIR)?
>>
>
> That might also help get rid of an annoying failure mode where some
> git commands (the shell script ones) fail if you cd into a git
> repository via a symlink, while others (the builtins) work just fine.
It might be the easiest workaround for this issue to unset PWD
in git-sh-setup.sh (and git-clone.sh) where we unset CDPATH.
Anybody wants to try to come up with additional test scripts to
expose the problem and a patch to these two files?
prev parent reply other threads:[~2007-08-11 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 14:02 [PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR David Kastrup
2007-08-10 16:21 ` [fixed PATCH] " David Kastrup
2007-08-11 10:06 ` Junio C Hamano
2007-08-11 10:32 ` David Kastrup
2007-08-11 12:12 ` David Kastrup
2007-08-11 12:29 ` David Kastrup
2007-08-11 19:53 ` Junio C Hamano
2007-08-11 21:04 ` David Kastrup
2007-08-11 22:02 ` [PATCH] Add a test for git-commit being confused by relative GIT_DIR David Kastrup
2007-08-12 1:55 ` Junio C Hamano
2007-08-12 6:47 ` David Kastrup
2007-08-12 17:05 ` Junio C Hamano
2007-08-12 18:44 ` David Kastrup
2007-08-11 12:51 ` [fixed PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR Steven Grimm
2007-08-11 20:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vveblltmw.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=koreth@midwinter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox