From: David Kastrup <dak@gnu.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [fixed PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR
Date: Sat, 11 Aug 2007 23:04:54 +0200 [thread overview]
Message-ID: <857io1u6ix.fsf@lola.goethe.zz> (raw)
In-Reply-To: <7vbqddn8zj.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Sat\, 11 Aug 2007 12\:53\:36 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> I think your other patch to always give full path to the shell
> scripts from git-sh-setup makes sense. Could you please make
> test scripts to expose the problems you described in the message
> I am replying to and add it as say t/t2050-git-dir-relative.sh?
It is actually a bit harder to trigger than I expected: if GIT_DIR is
not a direct descendant of the current directory, git-rev-parse does
output an absolute path. So at least for the test failure in
git-commit, I have to revert to a non-run-of-the-mill setup.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-08-11 21:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 14:02 [PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR David Kastrup
2007-08-10 16:21 ` [fixed PATCH] " David Kastrup
2007-08-11 10:06 ` Junio C Hamano
2007-08-11 10:32 ` David Kastrup
2007-08-11 12:12 ` David Kastrup
2007-08-11 12:29 ` David Kastrup
2007-08-11 19:53 ` Junio C Hamano
2007-08-11 21:04 ` David Kastrup [this message]
2007-08-11 22:02 ` [PATCH] Add a test for git-commit being confused by relative GIT_DIR David Kastrup
2007-08-12 1:55 ` Junio C Hamano
2007-08-12 6:47 ` David Kastrup
2007-08-12 17:05 ` Junio C Hamano
2007-08-12 18:44 ` David Kastrup
2007-08-11 12:51 ` [fixed PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR Steven Grimm
2007-08-11 20:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857io1u6ix.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox