From: Danh Doan <congdanhqx@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, mduft@gentoo.org,
stefano.lattarini@gmail.com, kusmabite@gmail.com
Subject: Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h
Date: Wed, 14 Nov 2018 12:32:29 +0700 [thread overview]
Message-ID: <87h8gkrzpu.fsf@congdanhqx.xyz> (raw)
In-Reply-To: <20181114014307.GM890086@genre.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> - t1308.23 is failing because musl `fopen` is success when open directory
>> in readonly mode. POSIX allows this behavior:
>> http://pubs.opengroup.org/onlinepubs/7908799/xsh/fopen.html
>> [EISDIR]
>> The named file is a directory and mode requires write access.
>
> Does setting FREAD_READS_DIRECTORIES fix this?
Yes, setting FREAD_READS_DIRECTORIES fixes this.
And, `configure` can set that itself.
I blindly followed the Void's build template which explicitly unset it
in the configure script without investigating it.
My bad!
I'll send them a patch to fix this downstream.
> --
> brian m. carlson: Houston, Texas, US
> OpenPGP: https://keybase.io/bk2204
--
Danh
next prev parent reply other threads:[~2018-11-14 5:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 1:10 [PATCH] git-compat-util: prefer poll.h to sys/poll.h Đoàn Trần Công Danh
2018-11-14 1:43 ` brian m. carlson
2018-11-14 4:48 ` Junio C Hamano
2018-11-14 5:32 ` Danh Doan [this message]
2018-11-14 7:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8gkrzpu.fsf@congdanhqx.xyz \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=mduft@gentoo.org \
--cc=sandals@crustytoothpaste.net \
--cc=stefano.lattarini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox