Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org, mduft@gentoo.org,
	stefano.lattarini@gmail.com, kusmabite@gmail.com
Subject: Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h
Date: Wed, 14 Nov 2018 16:32:16 +0900	[thread overview]
Message-ID: <xmqq5zx0nmgv.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181114011043.27419-1-congdanhqx@gmail.com> ("Đoàn Trần Công Danh"'s message of "Wed, 14 Nov 2018 08:10:43 +0700")

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

> -#ifndef NO_SYS_POLL_H
> +#if !defined(NO_POLL_H)
> +#include <poll.h>
> +#elif !defined(NO_SYS_POLL_H)
>  #include <sys/poll.h>
>  #else
> +/* Pull the compat stuff */
>  #include <poll.h>
>  #endif

The last comment would help readers who got "Huh?  When NO_POLL_H
and NO_SYS_POLL_H is given, we still include <poll.h>" without it.

Looks good.  Thanks.

      parent reply	other threads:[~2018-11-14  7:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14  1:10 [PATCH] git-compat-util: prefer poll.h to sys/poll.h Đoàn Trần Công Danh
2018-11-14  1:43 ` brian m. carlson
2018-11-14  4:48   ` Junio C Hamano
2018-11-14  5:32   ` Danh Doan
2018-11-14  7:32 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zx0nmgv.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@gmail.com \
    --cc=mduft@gentoo.org \
    --cc=stefano.lattarini@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox