From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
git@vger.kernel.org, mduft@gentoo.org,
stefano.lattarini@gmail.com, kusmabite@gmail.com
Subject: Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h
Date: Wed, 14 Nov 2018 13:48:48 +0900 [thread overview]
Message-ID: <xmqqr2fop8lr.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181114014307.GM890086@genre.crustytoothpaste.net> (brian m. carlson's message of "Wed, 14 Nov 2018 01:43:07 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On Wed, Nov 14, 2018 at 08:10:43AM +0700, Đoàn Trần Công Danh wrote:
>> POSIX specifies that <poll.h> is the correct header for poll(2)
>> whereas <sys/poll.h> is only needed for some old libc.
>>
>> Let's follow the POSIX way by default.
>>
>> This effectively eliminates musl's warning:
>>
>> warning redirecting incorrect #include <sys/poll.h> to <poll.h>
>>
>> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
>
> I think this patch is fine. This was in SUSv2, and I don't feel bad
> about siding with a spec that's at least 17 years old.
Yup, I agree. Thanks, both.
next prev parent reply other threads:[~2018-11-14 4:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 1:10 [PATCH] git-compat-util: prefer poll.h to sys/poll.h Đoàn Trần Công Danh
2018-11-14 1:43 ` brian m. carlson
2018-11-14 4:48 ` Junio C Hamano [this message]
2018-11-14 5:32 ` Danh Doan
2018-11-14 7:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2fop8lr.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=mduft@gentoo.org \
--cc=sandals@crustytoothpaste.net \
--cc=stefano.lattarini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox