From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Karthik Nayak <karthik.188@gmail.com>, git@vger.kernel.org
Cc: gitster@pobox.com
Subject: Re: [PATCH v2 05/20] t9300: make the series V tests self-contained
Date: Fri, 20 Nov 2026 18:18:47 +0530 [thread overview]
Message-ID: <8c88dd99-dbfb-4207-bd43-64063795e907@gmail.com> (raw)
In-Reply-To: <20261112-kn-fast-import-tests-1-v2-5-b8c3a0ab27e8@gmail.com>
On 11/12/26 23:04, Karthik Nayak wrote:
> Similar to the previous commits, modify the tests in 'series V' to make
> them independent of state from previous tests.
>
> Move the setup to a 'setup_checkpoint_repo()' function, so each test can
> invoke it. The tests used to build on the 'U' branch from series U, so
> let the function create a 'base' commit instead. For the same reason,
> the tag test now tags 'base' and not 'V'.
>
> 'background_import_then_checkpoint()' registers a cleanup with
> 'test_when_finished', which is not allowed in a subshell, so call it
> from the main shell.
>
May be also mention that it sets fi_pid that
background_import_still_running_ expects?
> The 'no new objects' test needs the 'V' commit in a pack, because
> fast-import only detects duplicates against packs and not against loose
> objects. It used to rely on the 'fastimport.unpackLimit' set by an
> earlier test, so create the commit in the test with
> 'fastimport.unpackLimit' set to 0.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
>
> test_expect_success PIPE 'V: checkpoint updates tags after tag' '
> - cat >input <<-INPUT_END &&
> + setup_checkpoint_repo &&
> + cat >repo/input <<-INPUT_END &&
> tag Vtag
> - from refs/heads/V
> + from refs/heads/base
> tagger $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE
> data 0
>
> INPUT_END
>
> - background_import_then_checkpoint "" input &&
> - git show-ref -d Vtag &&
> + background_import_then_checkpoint "" repo/input &&
> + git -C repo show-ref -d Vtag &&
> background_import_still_running
> '
>
>
The way this test series is refactored is different but it is consistent
with how the commit message describes it to be.
LGTM.
--
Sivaraam
next prev parent reply other threads:[~2026-11-20 12:48 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:49 [PATCH 00/20] t9300: group and move tests to other files Karthik Nayak
2026-11-10 11:49 ` [PATCH 01/20] t9300: move 'fastimport.unpackLimit' to the required test Karthik Nayak
2026-11-10 11:49 ` [PATCH 02/20] t9300: make the series B tests self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 03/20] t9300: make the series T " Karthik Nayak
2026-11-10 11:49 ` [PATCH 04/20] t9300: make the series S " Karthik Nayak
2026-11-10 11:49 ` [PATCH 05/20] t9300: make the series V " Karthik Nayak
2026-11-10 11:49 ` [PATCH 06/20] t9300: make the series Q " Karthik Nayak
2026-11-10 11:49 ` [PATCH 07/20] t9300: make the series P " Karthik Nayak
2026-11-10 11:49 ` [PATCH 08/20] t9300: make the series O " Karthik Nayak
2026-11-10 11:49 ` [PATCH 09/20] t9300: make the big blob " Karthik Nayak
2026-11-10 11:49 ` [PATCH 10/20] t9300: make the ref update " Karthik Nayak
2026-11-10 11:49 ` [PATCH 11/20] t9300: make the date format " Karthik Nayak
2026-11-10 11:49 ` [PATCH 12/20] t9300: make the pack edges test self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 13/20] t9300: make the marks tests self-contained Karthik Nayak
2026-11-10 11:49 ` [PATCH 14/20] t9300: make the series Y " Karthik Nayak
2026-11-10 11:50 ` [PATCH 15/20] t9300: make the cat-blob " Karthik Nayak
2026-11-10 11:50 ` [PATCH 16/20] t9300: make the feature and option " Karthik Nayak
2026-11-10 11:50 ` [PATCH 17/20] t9300: make the stream " Karthik Nayak
2026-11-10 11:50 ` [PATCH 18/20] t9300: make the get-mark and encoding " Karthik Nayak
2026-11-10 11:50 ` [PATCH 19/20] t9300: move self-contained tests into dedicated files Karthik Nayak
2026-11-10 11:50 ` [PATCH 20/20] t93xx: drop the series letter from the moved test names Karthik Nayak
2026-11-10 16:45 ` [PATCH 00/20] t9300: group and move tests to other files Junio C Hamano
2026-11-10 20:06 ` Junio C Hamano
2026-11-11 11:22 ` Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 01/20] t9300: move 'fastimport.unpackLimit' to the required test Karthik Nayak
2026-11-19 10:06 ` Kaartic Sivaraam
2026-11-12 17:34 ` [PATCH v2 02/20] t9300: make the series B tests self-contained Karthik Nayak
2026-11-19 12:22 ` Kaartic Sivaraam
2026-11-12 17:34 ` [PATCH v2 03/20] t9300: make the series T " Karthik Nayak
2026-11-19 12:45 ` Kaartic Sivaraam
2026-11-12 17:34 ` [PATCH v2 04/20] t9300: make the series S " Karthik Nayak
2026-11-19 18:27 ` Kaartic Sivaraam
2026-11-12 17:34 ` [PATCH v2 05/20] t9300: make the series V " Karthik Nayak
2026-11-20 12:48 ` Kaartic Sivaraam [this message]
2026-11-12 17:34 ` [PATCH v2 06/20] t9300: make the series Q " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 07/20] t9300: make the series P " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 08/20] t9300: make the series O " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 09/20] t9300: make the big blob " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 10/20] t9300: make the ref update " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 11/20] t9300: make the date format " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 12/20] t9300: make the pack edges test self-contained Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 13/20] t9300: make the marks tests self-contained Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 14/20] t9300: make the series Y " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 15/20] t9300: make the cat-blob " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 16/20] t9300: make the feature and option " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 17/20] t9300: make the stream " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 18/20] t9300: make the get-mark and encoding " Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 19/20] t9300: move self-contained tests into dedicated files Karthik Nayak
2026-11-12 17:34 ` [PATCH v2 20/20] t93xx: drop the series letter from the moved test names Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c88dd99-dbfb-4207-bd43-64063795e907@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox