Git development
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Chris Frey <cdfrey@foursquare.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Alex Riesen <raa.lkml@gmail.com>,
	Junio C Hamano <gitster@pobox.com>, Miles Bader <miles@gnu.org>,
	git@vger.kernel.org
Subject: Re: multiple-commit cherry-pick?
Date: Fri, 14 Nov 2008 08:11:41 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0811140800540.3468@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20081114050822.GA23963@foursquare.net>



On Fri, 14 Nov 2008, Chris Frey wrote:
> 
> Would it be possible to add "range" support to a subset of commands by
> using a git-range wrapper?

It would be better to just extend the SHA-1 arithmetic. We could do it, no 
problem. It's just a SMOP.

For example, right now the arithmetic is entirely "flat", with no 
precedence, no nesting, nothing but a single level of set operations. We 
could extend it to be hierarchical.

So we _could_ do something like

	git log {a..b} {c..d ^e}

and just declare that { $args } is a self-contained "subset", and 
effectively becomes the same thing as "$(git rev-list $args)" but with 
magic no-walking semantics (ie all walking is done only _within_ the { }, 
not between different groups.

You literally _can_ do it right now that way:

	git log --no-walk $(git rev-list HEAD~5..HEAD~3) $(git rev-list HEAD~1..)

actually works, but that will hit argument size limits on many platforms 
really quickly.

So we could make a '{ }' in the argument space basically do a SHA1 
expansion of the range inside, and imply --no-walk. It's _not_ entirely 
trivial, because we'd need to handle the fact that object flags are 
sticky, and clear them in between invocations of multiple ranges, but it's 
not _fundmanetally_ difficult. It's just that somebody would need to do 
it.

		Linus

  parent reply	other threads:[~2008-11-14 16:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06  2:45 multiple-commit cherry-pick? Miles Bader
2008-11-06  3:24 ` Deskin Miller
2008-11-06  9:51   ` Björn Steinbrink
2008-11-06 12:14     ` Miles Bader
2008-11-06 12:26       ` Björn Steinbrink
2008-11-07  5:09         ` Miles Bader
2008-11-07 11:03           ` Björn Steinbrink
2008-11-07 11:46             ` Miles Bader
2008-11-06 21:37 ` Alex Riesen
2008-11-07  3:29   ` Linus Torvalds
2008-11-07  4:38     ` Miles Bader
2008-11-07  7:13       ` Alex Riesen
2008-11-07  5:00     ` Junio C Hamano
2008-11-07  7:12       ` Alex Riesen
2008-11-07 18:08         ` Linus Torvalds
2008-11-09 10:25           ` Alex Riesen
2008-11-10 19:58             ` Johannes Schindelin
2008-11-10 20:24               ` Alex Riesen
2008-11-10 21:31                 ` Johannes Schindelin
2008-11-14  5:08                   ` Chris Frey
2008-11-14 14:00                     ` Johannes Schindelin
2008-11-14 16:11                     ` Linus Torvalds [this message]
2008-11-14 16:59                       ` Johannes Schindelin
2008-11-14 17:29                       ` Junio C Hamano
2008-11-14 17:41                         ` Linus Torvalds
2008-11-14 17:55                           ` Linus Torvalds
2008-11-16  9:11                             ` Pierre Habouzit
2008-11-14 18:38                       ` Francis Galiegue
2008-11-10 20:41               ` Junio C Hamano
2008-11-10 21:34                 ` Johannes Schindelin
2008-11-07 10:46       ` Michael Radziej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0811140800540.3468@nehalem.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=cdfrey@foursquare.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=miles@gnu.org \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox