Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/4] Improve performance of reflog expiration
Date: Thu, 19 Nov 2026 12:58:56 +0100	[thread overview]
Message-ID: <av7kgOuPOugFsCbr@pks.im> (raw)
In-Reply-To: <87bj7mjfp2.fsf@dev.null.iotcl.com.invalid>

On Wed, Nov 18, 2026 at 04:56:57PM +0100, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Hi,
> >
> > I recently noticed that a bunch of commands started hanging for almost a
> > second after they're essentially done already. As it turns out, this was
> > caused by auto-maintenance, which was blocking in the foreground for
> > ~800ms.
> >
> > The root cause of this is that the auto-condition of "reflog-expire"
> > doesn't properly evaluate reachability of reflog entries, so it instead
> > considered every single reflog entry to point to an unreachable commit.
> > Hence, all entries were evaluated against "gc.reflogExpireUnreachable"
> > instead of "gc.reflogExpire", and thus the auto-condition significantly
> > overcounts the number of entries that we'd prune. So every single run of
> > git-maintenance(1) ultimately ended up spawning `git reflog expire`.
> >
> > This is fixed by the last patch in this series.
> 
> Well, the last one is a doc change, but I get what you mean.

Oops, true, this one is stale. I only added that last commit after
having written the cover letter.

Patrick

      reply	other threads:[~2026-11-19 11:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  9:30 [PATCH 0/4] Improve performance of reflog expiration Patrick Steinhardt
2026-11-18  9:31 ` [PATCH 1/4] refs/reftable: don't write new table on dry-run expire Patrick Steinhardt
2026-11-18 11:28   ` Karthik Nayak
2026-11-18 12:05     ` Patrick Steinhardt
2026-11-18 16:51   ` Junio C Hamano
2026-11-19 11:59     ` Patrick Steinhardt
2026-11-18  9:31 ` [PATCH 2/4] refs/reftable: don't write new table when expire is a no-op Patrick Steinhardt
2026-11-18 11:33   ` Karthik Nayak
2026-11-18 12:05     ` Patrick Steinhardt
2026-11-18 15:34   ` Toon Claes
2026-11-19 11:57     ` Patrick Steinhardt
2026-11-18  9:31 ` [PATCH 3/4] builtin/maintenance: only consider `gc.reflogExpire` for "--auto" Patrick Steinhardt
2026-11-18 15:52   ` Toon Claes
2026-11-19 11:58     ` Patrick Steinhardt
2026-11-18  9:31 ` [PATCH 4/4] Documentation/config: fix typo in "maintenance.reflog-expire.auto" Patrick Steinhardt
2026-11-18 15:54   ` Toon Claes
2026-11-18 15:56 ` [PATCH 0/4] Improve performance of reflog expiration Toon Claes
2026-11-19 11:58   ` Patrick Steinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7kgOuPOugFsCbr@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox