* [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_() [not found] <1a15474a4114ba8b> @ 2026-10-19 15:27 ` kerylefondji7 2026-10-20 9:42 ` Phillip Wood 0 siblings, 1 reply; 2+ messages in thread From: kerylefondji7 @ 2026-10-19 15:27 UTC (permalink / raw) To: git Cc: phillipwood123, gitster, christiancouder, siddharthasthana31, Keryle Fondji From: Keryle Fondji <kerylefondji7@gmail.com> Replace _() with Q_() in the 'path too long' error message. Although pathlen is always greater than 0xffff when this error is hit, Q_() is required to support correct translation for languages that require different plural forms depending on the count. Signed-off-by: Keryle Fondji <kerylefondji7@gmail.com> --- archive-zip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archive-zip.c b/archive-zip.c index 6f73ca6d58..e4f8ef5a36 100644 --- a/archive-zip.c +++ b/archive-zip.c @@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args, } if (pathlen > 0xffff) { - return error(_("path too long (%d chars, SHA1: %s): %s"), + return error(Q_("path too long (%d char, SHA1: %s): %s", "path too long (%d chars, SHA1: %s): %s", pathlen), (int)pathlen, oid_to_hex(oid), path); } -- 2.53.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_() 2026-10-19 15:27 ` [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_() kerylefondji7 @ 2026-10-20 9:42 ` Phillip Wood 0 siblings, 0 replies; 2+ messages in thread From: Phillip Wood @ 2026-10-20 9:42 UTC (permalink / raw) To: kerylefondji7, git Cc: phillipwood123, gitster, christiancouder, siddharthasthana31 Hi Keryle On 19/10/2026 16:27, kerylefondji7@gmail.com wrote: > From: Keryle Fondji <kerylefondji7@gmail.com> > > Replace _() with Q_() in the 'path too long' error message. Although > pathlen is always greater than 0xffff when this error is hit, Q_() is > required to support correct translation for languages that require > different plural forms depending on the count. This is good. As Junio has pointed out the code needs wrapping now that it is using Q_(). Thanks Phillip > Signed-off-by: Keryle Fondji <kerylefondji7@gmail.com> > --- > archive-zip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/archive-zip.c b/archive-zip.c > index 6f73ca6d58..e4f8ef5a36 100644 > --- a/archive-zip.c > +++ b/archive-zip.c > @@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args, > } > > if (pathlen > 0xffff) { > - return error(_("path too long (%d chars, SHA1: %s): %s"), > + return error(Q_("path too long (%d char, SHA1: %s): %s", "path too long (%d chars, SHA1: %s): %s", pathlen), > (int)pathlen, oid_to_hex(oid), path); > } > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-20 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1a15474a4114ba8b>
2026-10-19 15:27 ` [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_() kerylefondji7
2026-10-20 9:42 ` Phillip Wood
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox