From: Junio C Hamano <gitster@pobox.com>
To: "Matt Hunter" <m@lfurio.us>
Cc: "Colin Hinton" <colinlewishinton@gmail.com>, <git@vger.kernel.org>
Subject: Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation
Date: Fri, 06 Nov 2026 08:15:10 -0800 [thread overview]
Message-ID: <xmqq1p8ylywh.fsf@gitster.g> (raw)
In-Reply-To: <DMO0XC1PL4MP.1J5830XZ4GCS5@lfurio.us> (Matt Hunter's message of "Fri, 06 Nov 2026 04:34:46 -0500")
"Matt Hunter" <m@lfurio.us> writes:
> On Thu Nov 5, 2026 at 11:03 PM EST, Junio C Hamano wrote:
>>
>> Hmph, interesting. Can you rewrite Colin's patch using this, and
>> then merge the result into 'seen' (after reverting Colin's topic
>> ch/remote-defer-follow-remote-head-validation from 'seen' first) to
>> see how badly it crashes with other topics in flight?
>
> I still have the commit sitting around. I tried this and a replay of
> the current topic to compare -- the conflict is the same in both
> cases. eg: Nothing else in flight is touching the
> get_follow_remote_head() function.
Thanks for investigating.
Your approach of passing more context into get_follow_remote_head()
and have _it_ do the (lazy) conversion from string to value makes it
much easier for callers to make calls from multiple branches to the
function, because the need to "set-up" to make the call disappears.
Very cleanly done.
Colin, what's your preference? Can we move this topic past the
finish line?
Thanks.
prev parent reply other threads:[~2026-11-06 16:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 23:55 [PATCH v1] remote.c: defer remote.<name>.followRemoteHEAD validation Colin Hinton
2026-10-19 15:37 ` Junio C Hamano
2026-10-19 21:24 ` Matt Hunter
2026-10-21 16:30 ` Colin Hinton
2026-10-22 12:39 ` Matt Hunter
2026-10-23 18:50 ` [PATCH v2] " Colin Hinton
2026-10-23 21:59 ` Junio C Hamano
2026-10-24 9:28 ` Matt Hunter
2026-10-24 16:47 ` Junio C Hamano
2026-10-25 2:16 ` Junio C Hamano
2026-10-28 2:56 ` Colin Hinton
2026-10-28 14:26 ` Junio C Hamano
2026-10-30 7:04 ` Matt Hunter
2026-10-30 15:12 ` Junio C Hamano
2026-11-01 0:00 ` Matt Hunter
2026-11-06 4:03 ` Junio C Hamano
2026-11-06 9:34 ` Matt Hunter
2026-11-06 16:15 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1p8ylywh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=colinlewishinton@gmail.com \
--cc=git@vger.kernel.org \
--cc=m@lfurio.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox