Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Matt Hunter" <m@lfurio.us>
Cc: "Colin Hinton" <colinlewishinton@gmail.com>,  <git@vger.kernel.org>
Subject: Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation
Date: Thu, 05 Nov 2026 20:03:40 -0800	[thread overview]
Message-ID: <xmqqjymqobc3.fsf@gitster.g> (raw)
In-Reply-To: <DMJFKJCI5DLL.12R7AMFO4DK2Y@lfurio.us> (Matt Hunter's message of "Sat, 31 Oct 2026 20:00:00 -0400")

"Matt Hunter" <m@lfurio.us> writes:

> I should explain myself better.  I don't mean Colin should avoid
> splitting out logic from the main flow in do_fetch.  But the end result
> can be reached without introducing a new function.  I find needing to
> hold fewer functions in my head makes the code easier to reason about,
> though that is a subjective point.
>
> The idea in my head is below and is
> Signed-off-by: Matt Hunter <m@lfurio.us>
> Feel free to run with this or not.

Hmph, interesting.  Can you rewrite Colin's patch using this, and
then merge the result into 'seen' (after reverting Colin's topic
ch/remote-defer-follow-remote-head-validation from 'seen' first) to
see how badly it crashes with other topics in flight?

Thanks.




  reply	other threads:[~2026-11-06  4:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18 23:55 [PATCH v1] remote.c: defer remote.<name>.followRemoteHEAD validation Colin Hinton
2026-10-19 15:37 ` Junio C Hamano
2026-10-19 21:24 ` Matt Hunter
2026-10-21 16:30   ` Colin Hinton
2026-10-22 12:39     ` Matt Hunter
2026-10-23 18:50 ` [PATCH v2] " Colin Hinton
2026-10-23 21:59   ` Junio C Hamano
2026-10-24  9:28   ` Matt Hunter
2026-10-24 16:47     ` Junio C Hamano
2026-10-25  2:16   ` Junio C Hamano
2026-10-28  2:56     ` Colin Hinton
2026-10-28 14:26       ` Junio C Hamano
2026-10-30  7:04         ` Matt Hunter
2026-10-30 15:12           ` Junio C Hamano
2026-11-01  0:00             ` Matt Hunter
2026-11-06  4:03               ` Junio C Hamano [this message]
2026-11-06  9:34                 ` Matt Hunter
2026-11-06 16:15                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqjymqobc3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=colinlewishinton@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=m@lfurio.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox