Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: ps@pks.im,  sandals@crustytoothpaste.net, Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH v5] move rust gitcore crate to a different subdirectory
Date: Tue, 27 Oct 2026 15:57:02 -0700	[thread overview]
Message-ID: <xmqqh5i6g3b5.fsf@gitster.g> (raw)
In-Reply-To: <20260917060415.2986259-1-mh@glandium.org> (Mike Hommey's message of "Thu, 17 Sep 2026 15:04:15 +0900")

Mike Hommey <mh@glandium.org> writes:

> Having `Cargo.toml` at the top-level of the repository implies that one
> can run `cargo build` directly, but this doesn't produce anything useful
> on its own.
>
> Additionally, when including the git source as a submodule of a Rust
> project, it prevents the git source from being included at all in the
> crate package because cargo skips directories that contain a Cargo.toml,
> assuming that everything in the directory is relevant to the crate.
>
> Move all Rust-specific files into a dedicated `rust/` subdirectory.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---

I was looking at discussions that are older than a month whose
patches are not near 'next', and found this patch, which we haven't
seen any comments or updates on the discussion thread.

It does not seem nobody, other than the original poster, for obvious
reasons, was enthused by the topic, and given that the exchange on
"what happens post Git 3.0?", I am not sure how badly we want to
keep this topic.


      parent reply	other threads:[~2026-10-27 22:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 23:22 [RFC PATCH] Move rust gitcore crate to a different subdirectory Mike Hommey
2026-02-05  0:10 ` brian m. carlson
2026-02-05  1:45   ` Mike Hommey
2026-02-05  2:06     ` brian m. carlson
2026-02-05  4:55       ` Mike Hommey
2026-02-09 22:48 ` [PATCH v2] " Mike Hommey
2026-09-09  1:38   ` [PATCH v3] " Mike Hommey
2026-09-09 19:54     ` Junio C Hamano
2026-09-10 12:09       ` Mike Hommey
2026-09-09 21:13     ` brian m. carlson
2026-09-10 12:05       ` Mike Hommey
2026-09-10  6:27     ` Tuomas Ahola
2026-09-10 12:21       ` Junio C Hamano
2026-09-10 12:10     ` [PATCH v4] " Mike Hommey
2026-09-10 17:45       ` Junio C Hamano
2026-09-17  6:04         ` [PATCH v5] move " Mike Hommey
2026-09-18  8:20           ` Junio C Hamano
2026-09-18 15:02             ` Mike Hommey
2026-10-27 22:57           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh5i6g3b5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mh@glandium.org \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox