From: Junio C Hamano <gitster@pobox.com>
To: "Farid Zakaria" <farid.m.zakaria@gmail.com>
Cc: <git@vger.kernel.org>, "Jeff King" <peff@peff.net>,
"Patrick Steinhardt" <ps@pks.im>,
"M Hickford" <mirth.hickford@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Jeff Hostetler" <jeffhostetler@github.com>
Subject: Re: [PATCH v2 0/3] credential-cache: fix two races when daemons start at once
Date: Mon, 09 Nov 2026 13:24:51 -0800 [thread overview]
Message-ID: <xmqqwlqlwvdo.fsf@gitster.g> (raw)
In-Reply-To: <DMPJNBIHZB35.1EJF34BS6RR9@gmail.com> (Farid Zakaria's message of "Sat, 07 Nov 2026 20:27:43 -0800")
"Farid Zakaria" <farid.m.zakaria@gmail.com> writes:
> On Sat Nov 7, 2026 at 5:56 PM PST, Junio C Hamano wrote:
>> "Farid Zakaria" <farid.m.zakaria@gmail.com> writes:
>> ...
>>> was meant to say: I did not address it but I can if we think it's
>>> necessary.
>
> I'm not sure how you want me to respond here;
> I made an attempt at a fix for an issue I came across
> within the context I felt comfortable to contribute.
I was asking why you needed to question "if it is necessary" in the
first place when somebody points out a potential issue in your
proposed solution. If it is not necessary to be corrected, I do not
see why anybody spends time to point it out.
"It is not necessary to worry about this case because it will not
happen for such and such reasons" is a very valid thing to say in
response, but "I can address it if we think it's necessary" does
not move us forward.
prev parent reply other threads:[~2026-11-09 21:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 23:29 [PATCH 0/2] credential-cache: fix two races when daemons start at once Farid Zakaria
2026-11-01 23:29 ` [PATCH 1/2] credential-cache--daemon: allow a concurrently created socket dir Farid Zakaria
2026-11-03 8:01 ` Patrick Steinhardt
2026-11-04 18:25 ` Farid Zakaria
2026-11-04 2:58 ` Jeff King
2026-11-01 23:29 ` [PATCH 2/2] credential-cache--daemon: do not take over a running daemon's socket Farid Zakaria
2026-11-03 8:01 ` Patrick Steinhardt
2026-11-04 18:28 ` Farid Zakaria
2026-11-03 17:24 ` Junio C Hamano
2026-11-04 3:07 ` Jeff King
2026-11-04 19:53 ` [PATCH v2 0/3] credential-cache: fix two races when daemons start at once Farid Zakaria
2026-11-04 19:53 ` [PATCH v2 1/3] credential-cache--daemon: do not apply core.sharedRepository Farid Zakaria
2026-11-09 7:55 ` Patrick Steinhardt
2026-11-04 19:53 ` [PATCH v2 2/3] credential-cache--daemon: allow a concurrently created socket dir Farid Zakaria
2026-11-09 7:55 ` Patrick Steinhardt
2026-11-04 19:53 ` [PATCH v2 3/3] credential-cache--daemon: do not take over a running daemon's socket Farid Zakaria
2026-11-05 7:39 ` [PATCH v2 0/3] credential-cache: fix two races when daemons start at once Junio C Hamano
2026-11-06 18:45 ` Farid Zakaria
2026-11-08 1:56 ` Junio C Hamano
2026-11-08 4:27 ` Farid Zakaria
2026-11-09 21:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwlqlwvdo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=farid.m.zakaria@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhostetler@github.com \
--cc=mirth.hickford@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox