Re: [igt-dev] [PATCH v17 1/7] lib/igt_gt: remove unnecessary argument

[Caz Yokoyama <Caz.Yokoyama@intel.com>]

Reviewed-by: Caz Yokoyama <caz.yokoyama@intel.com>

On Fri, 2019-04-05 at 04:07 +0300, Andi Shyti wrote:
> From: Andi Shyti <andi.shyti@intel.com>
> 
> __for_each_engine_class_instance(fd, e) doesn't need and doesn't
> use the fd argument. Remove it.
> 
> Signed-off-by: Andi Shyti <andi.shyti@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  lib/igt_gt.h     | 2 +-
>  tests/perf_pmu.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_gt.h b/lib/igt_gt.h
> index 54e95da98084..475c0b3c3cc6 100644
> --- a/lib/igt_gt.h
> +++ b/lib/igt_gt.h
> @@ -114,7 +114,7 @@ void gem_require_engine(int gem_fd,
>  	igt_require(gem_has_engine(gem_fd, class, instance));
>  }
>  
> -#define __for_each_engine_class_instance(fd__, e__) \
> +#define __for_each_engine_class_instance(e__) \
>  	for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)
>  
>  #define for_each_engine_class_instance(fd__, e__) \
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 1a08f564b066..4f552bc2ae28 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -1693,7 +1693,7 @@ igt_main
>  	igt_subtest("invalid-init")
>  		invalid_init();
>  
> -	__for_each_engine_class_instance(fd, e) {
> +	__for_each_engine_class_instance(e) {
>  		const unsigned int pct[] = { 2, 50, 98 };
>  
>  		/**
> @@ -1897,7 +1897,7 @@ igt_main
>  			gem_quiescent_gpu(fd);
>  		}
>  
> -		__for_each_engine_class_instance(render_fd, e) {
> +		__for_each_engine_class_instance(e) {
>  			igt_subtest_group {
>  				igt_fixture {
>  					gem_require_engine(render_fd,

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev